Bug 274323 - chinese/opencc: Update to 1.1.6
Summary: chinese/opencc: Update to 1.1.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-07 07:46 UTC by hiyorin
Modified: 2023-10-09 07:45 UTC (History)
2 users (show)

See Also:
lichray: maintainer-feedback+

Attachments
patch file (3.57 KB, text/plain)
2023-10-07 07:46 UTC, hiyorin 		fuz: maintainer-approval+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hiyorin 2023-10-07 07:46:37 UTC 
Created attachment 245476 [details]
patch file

Update to 1.1.6

Changes:        https://github.com/BYVoid/OpenCC/blob/master/NEWS.md
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-10-07 16:01:53 UTC 
Dear maintainer, do you approve of the patch?
Comment 2 lichray 2023-10-07 17:28:53 UTC 
Comment on attachment 245476 [details]
patch file

Yes. Do we still have the policy to approve patch separately? It seems that I cannot set a flag on the patch file.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-10-07 17:35:21 UTC 
Comment on attachment 245476 [details]
patch file

(In reply to lichray from comment #2)

The submitter forgot to set the maintainer-approval flag on the patch, so you can't toggle it unfortunately.  If this is the case, just write "I approve of the patch" or similar so the intent is clear.

Will commit with my next batch.
Comment 4 hiyorin 2023-10-07 18:09:44 UTC 
Thanks for approving the patch. 

I am not familiar with current workflow so I didn't notice about the maintainer-approval flag on the patch.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-10-09 07:43:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=96b523561b897c8e5fa4b661ad6d7aa22aa45c40

commit 96b523561b897c8e5fa4b661ad6d7aa22aa45c40
Author:     hiyorin@gmail.com <hiyorin@gmail.com>
AuthorDate: 2023-10-07 17:39:44 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-10-09 07:40:31 +0000

    chinese/opencc: update to 1.1.6

    Changelog: https://github.com/BYVoid/OpenCC/blob/master/NEWS.md

    PR:             274323
    Approved by:    lichray@gmail.com (maintainer)

 chinese/opencc/Makefile  |  3 +--
 chinese/opencc/distinfo  |  6 +++---
 chinese/opencc/pkg-plist | 46 ++++++++++++++++++++++++++++------------------
 3 files changed, 32 insertions(+), 23 deletions(-)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-10-09 07:45:39 UTC 
Thank you for your contribution.