Bug 274355 - devel/wasmer: Update to 4.2.2
Summary: devel/wasmer: Update to 4.2.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Robert Clausecker
URL: https://github.com/wasmerio/wasmer/bl...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-08 14:43 UTC by Krešimir Jozić
Modified: 2023-10-09 07:46 UTC (History)
1 user (show)

See Also:


Attachments
Update to 4.2.2 (34.81 KB, patch)
2023-10-08 14:43 UTC, Krešimir Jozić
kjozic: maintainer-approval+
Details | Diff
Update to 4.2.2 (34.99 KB, patch)
2023-10-08 19:24 UTC, Krešimir Jozić
kjozic: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krešimir Jozić 2023-10-08 14:43:26 UTC
Created attachment 245499 [details]
Update to 4.2.2
Comment 1 Krešimir Jozić 2023-10-08 14:45:51 UTC
Update to 4.2.2

Enable Singlepass and LLVM compilers.

Limit a number of threads to the number of CPU threads because of runtime issues.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-10-08 17:52:28 UTC
Thank you for your submission.

I see that your patch hardcodes /usr/local as a search path in a patch.  This is incorrect.  The user can install the package into any prefix he/she likes.  You must obey LOCALBASE here.

I recommend as follows: in the patch, use %%LOCALBASE%% for the directory.  Then, add a pre-configure target like

    pre-configure:
            ${REINPLACE_CMD} -e s,%%LOCALBASE%%,${LOCALBASE}, ${WRKSRC}/Makefile

to patch in the true LOCALBASE prefix.

Please check this issue and resubmit as appropriate.
Comment 3 Krešimir Jozić 2023-10-08 18:07:50 UTC
Rust compiler can't find libffi and libzstd, so I hardcoded search path to /usr/local/lib. It must be hardcoded because rust path search obviously doesn't work well on FreeBSD.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-10-08 18:17:55 UTC
(In reply to Krešimir Jozić from comment #3)

Yes, and /usr/local/lib is wrong.  While this is indeed the default LOCALBASE, the user can built package for whatever prefix he/she likes.  Please adapt the patch as I indicated previously so it patches in whatever LOCALBASE says instead of hard-coding /usr/local.
Comment 5 Krešimir Jozić 2023-10-08 19:24:16 UTC
Created attachment 245507 [details]
Update to 4.2.2
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-10-08 19:29:37 UTC
Thanks for the fix.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-10-09 04:54:07 UTC
One final issue I just noted: You have USES=llvm, which adds llvm as a build-time dependency.  Are you sure you won't need LLVM at runtime?
Comment 8 Krešimir Jozić 2023-10-09 06:04:13 UTC
As I am aware, everything is compiled inside of executable.
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-10-09 07:42:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6ab67bad1dcc637c580ec720ed13c614a005034b

commit 6ab67bad1dcc637c580ec720ed13c614a005034b
Author:     Krešimir Jozić <kjozic@gmail.com>
AuthorDate: 2023-10-08 14:40:31 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-10-09 07:40:32 +0000

    devel/wasmer: Update to 4.2.2

    Changelog: https://github.com/wasmerio/wasmer/blob/master/CHANGELOG.md#422---04102023

    PR:             274355

 devel/wasmer/Makefile                              |  17 ++-
 devel/wasmer/Makefile.crates                       |  74 +++++-----
 devel/wasmer/distinfo                              | 154 +++++++++++----------
 devel/wasmer/files/patch-Makefile (new)            |  11 ++
 ..._wasix_src_runtime_task__manager_tokio.rs (new) |  11 ++
 5 files changed, 154 insertions(+), 113 deletions(-)
Comment 10 Robert Clausecker freebsd_committer freebsd_triage 2023-10-09 07:46:13 UTC
Thank you for your contribution.