Bug 274532 - net-p2p/*arr: Switch back to converters/libiconv dependency
Summary: net-p2p/*arr: Switch back to converters/libiconv dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-17 08:42 UTC by Michiel van Baak Jansen
Modified: 2023-10-19 09:38 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback?


Attachments
0001-net-p2p-arr-Switch-back-to-converters-libiconv-depen.patch (4.12 KB, patch)
2023-10-17 08:42 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michiel van Baak Jansen 2023-10-17 08:42:41 UTC
Created attachment 245693 [details]
0001-net-p2p-arr-Switch-back-to-converters-libiconv-depen.patch

In PR 274169 all *arr ports were switched to use 'USES+=libiconv' instead of a hard dependency on the 'converters/libiconv' port.
Turns out, this is incorrect.

Specifically 'libMonoPosixHelper' (part of .NET) is compiled against the port, and will break when the port is not installed (incompatible with the base version of libiconv)

This patch moves all *arr ports back to RUN_DEPENDS on converters/libiconv

poudriere ok
Installed all updates on my setup (13.2 amd64) in production, and runs perfect.

Affects the following ports
net-p2p/lidarr
net-p2p/prowlarr
net-p2p/radarr
net-p2p/readarr
net-p2p/sonarr-devel

Since I'm the maintainer of all, and the update is the same for all, I added them all in one patch, Same as the patch it undoes.

Thanks to the servarr team for telling me about the error and explaining why the ports need the libiconv port instead of using the system iconv.
patch by me.
Comment 1 Mina Galić freebsd_triage 2023-10-17 12:18:16 UTC
Triage: Reporter is Maintainer, assign to ports@
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-10-19 09:37:16 UTC
Committed,

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-10-19 09:38:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2170798e835f90876b763b641ef2f9bd9f75530a

commit 2170798e835f90876b763b641ef2f9bd9f75530a
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2023-10-18 06:53:00 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-10-19 09:36:46 +0000

    net-p2p/*arr: Switch back to converters/libiconv dependency

    In PR 274169 all *arr ports were switched to use 'USES+=libiconv' instead of a
    hard dependency on the 'converters/libiconv' port.  Turns out, this is
    incorrect.

    Specifically 'libMonoPosixHelper' (part of .NET) is compiled against the port,
    and will break when the port is not installed (incompatible with the base
    version of libiconv)

    This patch moves all *arr ports back to RUN_DEPENDS on converters/libiconv

    PR:             274532
    Reported by:    michiel@vanbaak.eu (maintainer)

 net-p2p/lidarr/Makefile       | 4 +++-
 net-p2p/prowlarr/Makefile     | 5 +++--
 net-p2p/radarr/Makefile       | 4 +++-
 net-p2p/readarr/Makefile      | 4 +++-
 net-p2p/sonarr-devel/Makefile | 4 +++-
 5 files changed, 15 insertions(+), 6 deletions(-)