Bug 274656 - net/igmpproxy: Patch to fix membership query packet checksums.
Summary: net/igmpproxy: Patch to fix membership query packet checksums.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-22 20:30 UTC by leper
Modified: 2023-10-27 10:01 UTC (History)
2 users (show)

See Also:
fernape: maintainer-feedback+


Attachments
Patch that fixes the issue for me. (1.06 KB, patch)
2023-10-22 20:30 UTC, leper
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description leper 2023-10-22 20:30:36 UTC
Created attachment 245806 [details]
Patch that fixes the issue for me.

igmpproxy for quite some while, I suspect some change in 14.0, did not seem to work for me. After some debugging it seems the IGMPv2 membership query packets created had a wrong checksum, which lead some clients to ignore those and not send answers, thereby causing them to be dropped and streams being interrupted (after roughly ~12.5 sec, which is the protocol timeout).

Given that information I then found https://redmine.pfsense.org/issues/13929 and did some testing and that patch seems to fix the issue for me.
Comment 1 Franco Fichtner 2023-10-23 07:16:53 UTC
Comment on attachment 245806 [details]
Patch that fixes the issue for me.

Looks reasonable.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-10-23 14:44:54 UTC
Committed,

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-10-23 14:45:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5881889d20c6cc5bcdda34681c5c8bcc9f43defe

commit 5881889d20c6cc5bcdda34681c5c8bcc9f43defe
Author:     leper <blubblub@mail.ru>
AuthorDate: 2023-10-23 08:23:55 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-10-23 14:44:09 +0000

    net/igmpproxy:  Patch to fix membership query packet checksums.

    PR:             274656
    Reported by:    blubblub@mail.ru
    Approved by:    franco@opnsense.org (maintainer)

 net/igmpproxy/files/patch-src_igmp.c (new) | 11 +++++++++++
 1 file changed, 11 insertions(+)
Comment 4 Franco Fichtner 2023-10-27 07:29:15 UTC
Fernando, sorry for checking this too late but a revision bump is missing since this is a runtime fix.


Cheers,
Franco
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2023-10-27 10:01:15 UTC
(In reply to Franco Fichtner from comment #4)
You are absolutely right.
Should be fixed now.

Thanks for the heads up!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-10-27 10:01:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0e1a52c27bbda904ffe2261a055765503050334d

commit 0e1a52c27bbda904ffe2261a055765503050334d
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2023-10-27 09:58:56 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-10-27 09:58:56 +0000

    net/igmpproxy: Bump PORTREVISION

    After last update with runtime fix.

    PR:     274656
    Fixes:  5881889d20c6

 net/igmpproxy/Makefile | 1 +
 1 file changed, 1 insertion(+)