Bug 274674 - net/phpldapadmin: patch for php82
Summary: net/phpldapadmin: patch for php82
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-23 13:53 UTC by Krzysztof
Modified: 2023-10-27 06:38 UTC (History)
1 user (show)

See Also:
ports: merge-quarterly?

Attachments
poudriere testport log (27.95 KB, text/plain)
2023-10-23 13:53 UTC, Krzysztof 		no flags Details
update patch (2.69 KB, patch)
2023-10-23 13:54 UTC, Krzysztof 		ports: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof 2023-10-23 13:53:39 UTC 
Created attachment 245827 [details]
poudriere testport log

net/phpldapadmin needs some patches which support php82. I've made them on "production server". Patch was tested with poudriere to be sure that making package is correct.

I tested this patch with php81 - working correctly

Bump portrevision to be sure that port should be updated
Comment 1 Krzysztof 2023-10-23 13:54:12 UTC 
Created attachment 245828 [details]
update patch

And patch for the port
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-10-24 02:44:34 UTC 
Would you like for these fixes to be merged into the quarterly branch 2023Q4?  If yes, please set "merge-quarterly" to "?".
Comment 3 Krzysztof 2023-10-24 07:14:36 UTC 
I've checked merge-quarterly as you suggested :-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-10-27 06:34:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7e34c31b8b72c161e2494f8648d9c11f18c90684

commit 7e34c31b8b72c161e2494f8648d9c11f18c90684
Author:     Krzysztof <ports@bsdserwis.com>
AuthorDate: 2023-10-24 02:43:43 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-10-27 06:32:57 +0000

    net/phpldapadmin: patch for php82

    PR:             274674
    MFH:            2023Q4

 net/phpldapadmin/Makefile                                   |  1 +
 net/phpldapadmin/files/patch-lib_Template.php (new)         | 11 +++++++++++
 net/phpldapadmin/files/patch-lib_TemplateRender.php (new)   | 12 ++++++++++++
 net/phpldapadmin/files/patch-lib_page.php (new)             | 13 +++++++++++++
 .../files/patch-lib_schema__functions.php (new)             | 11 +++++++++++
 5 files changed, 48 insertions(+)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-10-27 06:35:50 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=53cf531244148545d848585be6206d4540baee0c

commit 53cf531244148545d848585be6206d4540baee0c
Author:     Krzysztof <ports@bsdserwis.com>
AuthorDate: 2023-10-24 02:43:43 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-10-27 06:35:09 +0000

    net/phpldapadmin: patch for php82

    PR:             274674
    MFH:            2023Q4
    (cherry picked from commit 7e34c31b8b72c161e2494f8648d9c11f18c90684)

 net/phpldapadmin/Makefile                                   |  1 +
 net/phpldapadmin/files/patch-lib_Template.php (new)         | 11 +++++++++++
 net/phpldapadmin/files/patch-lib_TemplateRender.php (new)   | 12 ++++++++++++
 net/phpldapadmin/files/patch-lib_page.php (new)             | 13 +++++++++++++
 .../files/patch-lib_schema__functions.php (new)             | 11 +++++++++++
 5 files changed, 48 insertions(+)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-10-27 06:38:24 UTC 
Thank you for your contribution.