Bug 274677 - www/webkit2-gtk3: fix build with lld 17
Summary: www/webkit2-gtk3: fix build with lld 17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks: 273753
  Show dependency tree / graph
 
Reported: 2023-10-23 16:46 UTC by Dimitry Andric
Modified: 2023-10-23 17:00 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
www/webkit2-gtk3: fix build with lld 17 (1.99 KB, patch)
2023-10-23 16:46 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2023-10-23 16:46:20 UTC 
Building www/webkit2-gtk3 with lld 17 results in the following link
errors:

  ld: error: version script assignment of 'global' to symbol 'bmalloc::PerThreadStorage<bmalloc::PerHeapKind<bmalloc::Cache> >::s_didInitialize' failed: symbol not defined
  ld: error: version script assignment of 'global' to symbol 'bmalloc::PerThreadStorage<bmalloc::PerHeapKind<bmalloc::Cache> >::s_key' failed: symbol not defined
  ld: error: version script assignment of 'global' to symbol 'bmalloc::vmPageSize()::cached' failed: symbol not defined

The mentioned symbols are no longer external, and have been removed in
upstream commits:

https://github.com/WebKit/WebKit/commit/655e1bb394f423d6c15de98f5874ab181076d016
https://github.com/WebKit/WebKit/commit/a1c80bec178456c109a62723ff937405cdb35b6b

Since the former does not apply cleanly due to edits in the ChangeLog,
merge the functional changes in a single port patch file.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-10-23 16:46:52 UTC 
Created attachment 245832 [details]
www/webkit2-gtk3: fix build with lld 17
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-23 16:56:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=89d10367e4ebaa6c7a04bfe51da9911fa8f03fa7

commit 89d10367e4ebaa6c7a04bfe51da9911fa8f03fa7
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-10-23 16:40:57 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-10-23 16:55:35 +0000

    www/webkit2-gtk3: fix build with lld 17

    Building www/webkit2-gtk3 with lld 17 results in the following link
    errors:

      ld: error: version script assignment of 'global' to symbol 'bmalloc::PerThreadStorage<bmalloc::PerHeapKind<bmalloc::Cache> >::s_didInitialize' failed: symbol not defined
      ld: error: version script assignment of 'global' to symbol 'bmalloc::PerThreadStorage<bmalloc::PerHeapKind<bmalloc::Cache> >::s_key' failed: symbol not defined
      ld: error: version script assignment of 'global' to symbol 'bmalloc::vmPageSize()::cached' failed: symbol not defined

    The mentioned symbols are no longer external, and have been removed in
    upstream commits:

    https://github.com/WebKit/WebKit/commit/655e1bb394f423d6c15de98f5874ab181076d016
    https://github.com/WebKit/WebKit/commit/a1c80bec178456c109a62723ff937405cdb35b6b

    Since the former does not apply cleanly due to edits in the ChangeLog,
    merge the functional changes in a single port patch file.

    PR:             274677
    Approved by:    gnome (blanket)
    MFH:            2023Q4

 .../files/patch-Source_WebKit_webkitglib-symbols.map (new)   | 12 ++++++++++++
 1 file changed, 12 insertions(+)