Bug 274725 - sysutils/limine: Update to 5.20231103.0
Summary: sysutils/limine: Update to 5.20231103.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-26 02:35 UTC by mintsuki
Modified: 2023-11-03 21:30 UTC (History)
1 user (show)

See Also:

Attachments
Upgrade patch (1.22 KB, patch)
2023-10-26 02:35 UTC, mintsuki 		no flags Details | Diff
Update patch (1.89 KB, patch)
2023-10-29 05:18 UTC, mintsuki 		no flags Details | Diff
Update patch (1.89 KB, patch)
2023-11-03 07:23 UTC, mintsuki 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mintsuki 2023-10-26 02:35:08 UTC 
Created attachment 245873 [details]
Upgrade patch

This patch upgrades the Limine bootloader to the latest version: 5.20231024.0.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-10-27 20:27:35 UTC 
Is there a changelog for this update?  Please place a link to the changelog in the URL field or list the changes in a comment.
Comment 2 mintsuki 2023-10-29 05:18:29 UTC 
Created attachment 245964 [details]
Update patch

Limine 5.20231029.0 was released upstream and it contains a ChangeLog file. I hope updating the bug to 5.20231029.0 from 5.20231024.0 suffices.
Comment 3 mintsuki 2023-11-03 07:23:57 UTC 
Created attachment 246075 [details]
Update patch
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-11-03 16:32:09 UTC 
(In reply to mintsuki from comment #3)

What changed between this patch and the previous one?
Comment 5 mintsuki 2023-11-03 18:14:37 UTC 
(In reply to Robert Clausecker from comment #4)

I updated the patch to the latest upstream version: 5.20231103.0 from 5.20231029.0.
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-11-03 19:20:32 UTC 
Can you please link the changelog so I can include it in the commit message?
You should do so whenever you submit a patch to update a port.
Comment 7 mintsuki 2023-11-03 21:15:43 UTC 
(In reply to Robert Clausecker from comment #6)

The changelog file is inside the tarball and generated upstream... what link should I provide?
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-11-03 21:19:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e28ca0b21024e32c697d2ba6aff1d1eeb187f498

commit e28ca0b21024e32c697d2ba6aff1d1eeb187f498
Author:     mintsuki <mintsuki@protonmail.com>
AuthorDate: 2023-11-03 07:20:20 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-03 21:16:25 +0000

    sysutils/limine: Update to 5.20231103.0

    PR:             274725

 sysutils/limine/Makefile  | 4 ++--
 sysutils/limine/distinfo  | 6 +++---
 sysutils/limine/pkg-plist | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
Comment 9 Robert Clausecker freebsd_committer freebsd_triage 2023-11-03 21:30:44 UTC 
A link to the changelog of some sort.  If you can't do that, include the changelog in the commit message of your patch file or add it as a commit.

A list of commits is usually a poor changelog, but if you don't have anything better...

Anyway, I've now pushed the patch without the changelog as some patches in my current batch need to be committed urgently.