Bug 274745 - databases/keydb: Improvements to port
Summary: databases/keydb: Improvements to port
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-26 18:28 UTC by Daniel Engberg
Modified: 2023-11-02 19:36 UTC (History)
1 user (show)

See Also:
zi: maintainer-feedback-

Attachments
Patch for keydb (5.77 KB, patch)
2023-10-26 18:28 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-10-26 18:28:08 UTC 
Created attachment 245898 [details]
Patch for keydb

* Fix COMMENT
* Unbundle (lib)linenoise
* Adjust compiler requirements to c++14-lang
* Use the more commmon V=1 setting for verbose output
* Move variables defined below port options to above for better readability
* Remove i386 workaround, users are likely not to run this on 32-bit boxes anyway
* Use localbase:ldflags helper

Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist, make test)
Poudriere testport OK 13.2-RELEASE (amd64)

Additional notes:
make test bombs even before these changes, plans?
We can probably unbundle lua too
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2023-10-26 18:33:47 UTC 
Not interested in these adjustments at this point in time.

Thanks
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-10-26 19:06:58 UTC 
At least fix make test that's clearly broken and leaves multiple processes running
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-02 19:36:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b85052364dd1e56cb8251cd47be0bc88b432892f

commit b85052364dd1e56cb8251cd47be0bc88b432892f
Author:     Ryan Steinmetz <zi@FreeBSD.org>
AuthorDate: 2023-11-02 19:35:07 +0000
Commit:     Ryan Steinmetz <zi@FreeBSD.org>
CommitDate: 2023-11-02 19:35:07 +0000

    databases/keydb: Remove broken tests support for now

    PR:             274745
    Reported by:    diizzy@

 databases/keydb/Makefile | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)