Bug 274846 - www/node16: Remove DTrace support to fix build with upcoming binutils 2.41
Summary: www/node16: Remove DTrace support to fix build with upcoming binutils 2.41
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL:
Keywords:
Depends on:
Blocks: 272853
  Show dependency treegraph
 
Reported: 2023-11-01 09:48 UTC by Yasuhiro Kimura
Modified: 2023-11-18 09:16 UTC (History)
1 user (show)

See Also:
yasu: maintainer-feedback-


Attachments
Patch file (3.65 KB, patch)
2023-11-01 09:48 UTC, Yasuhiro Kimura
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2023-11-01 09:48:20 UTC
Created attachment 246045 [details]
Patch file

* With binutils 2.41 build fails as following.
      LD_LIBRARY_PATH=/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.host:/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src; dtrace -64 "-I/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj/gen" -Isrc -C -G -s src/v8ustack.d -o "/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src/node_dtrace_ustack.o"
    dtrace: failed to compile script src/v8ustack.d: line 1: failed to resolve V8DBG_SMITAG: Unknown variable name
* This is because behaviour of objdump has changes with binutils 2.41. [1][2]
* On upstream DTrace support itself has been removed with Node.js 19.x.
* There is a pull request that says it fixes build error. [3]  I tried it but unfortunately it doesn't work as is expected.
* Upstream suggests me to remove DTrace support. [4]

Reference:      https://github.com/nodejs/node/issues/49991#issue-1920717730 [1]
Reference:      https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0a3137ce4c4b38ee8 [2]
Reference:      https://github.com/nodejs/node/pull/49992 [3]
Reference:      https://github.com/nodejs/node/pull/49992#issuecomment-1784231190 [4]
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2023-11-18 00:15:12 UTC
Maintainer timeout. Take.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-18 00:30:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=441ef340afa6dd362be8029998f3327917b0670e

commit 441ef340afa6dd362be8029998f3327917b0670e
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2023-11-01 09:00:55 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2023-11-18 00:27:06 +0000

    www/node16: Remove DTrace support to fix build with upcoming binutils 2.41

    * With binutils 2.41 build fails as following.
          LD_LIBRARY_PATH=/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.host:/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src; dtrace -64 "-I/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj/gen" -Isrc -C -G -s src/v8ustack.d -o "/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src/node_dtrace_ustack.o"
        dtrace: failed to compile script src/v8ustack.d: line 1: failed to resolve V8DBG_SMITAG: Unknown variable name
    * This is because behaviour of objdump has changes with binutils 2.41. [1][2]
    * On upstream DTrace support itself has been removed with Node.js 19.x.
    * There is a pull request that says it fixes build error. [3]  I tried
      it but unfortunately it doesn't work as is expected.
    * Upstream suggests me to remove DTrace support. [4]

    Reference:      https://github.com/nodejs/node/issues/49991#issue-1920717730 [1]
    Reference:      https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0a3137ce4c4b38ee8 [2]
    Reference:      https://github.com/nodejs/node/pull/49992 [3]
    Reference:      https://github.com/nodejs/node/pull/49992#issuecomment-1784231190 [4]
    PR:             274846
    Approved by:    maintainer timeout

 www/node16/Makefile  | 23 +++--------------------
 www/node16/pkg-plist |  1 -
 2 files changed, 3 insertions(+), 21 deletions(-)
Comment 3 Juraj Lutter freebsd_committer freebsd_triage 2023-11-18 09:16:17 UTC
Thanks. This PR slipped out of my radar.