Bug 274906 - textproc/py-python-lsp-jsonrpc: possible unnecessary run-time dependencies
Summary: textproc/py-python-lsp-jsonrpc: possible unnecessary run-time dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-04 14:08 UTC by John Hein
Modified: 2023-11-04 15:05 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rhurlin)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2023-11-04 14:08:19 UTC
textproc/py-python-lsp-jsonrpc has:

RUN_DEPENDS=    ${PYTHON_PKGNAMEPREFIX}setuptools>0:devel/py-setuptools@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}ujson>0:devel/py-ujson@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}wheel>0:devel/py-wheel@${PY_FLAVOR}


Does py-python-lsp-jsonrpc really have run-time dependencies on py-setuptools, py-setuptools_scm, and py-wheel?
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-11-04 15:00:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a721b47305eac2d636edea8102581fa9d9cc10c8

commit a721b47305eac2d636edea8102581fa9d9cc10c8
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2023-11-04 14:53:13 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2023-11-04 14:59:39 +0000

    textproc/py-python-lsp-jsonrpc: Remove run_depends

    It turned out that some runtime dependencies are not necessary. These
    were probably relics from the search for necessary dependencies for the
    test target. Thanks to John Hein for the hint.

    PR:             274906
    MFH:            2023Q4

 textproc/py-python-lsp-jsonrpc/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-04 15:01:25 UTC
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4a995dfa52f8c4e4ed15694a5d1d77aa25102d29

commit 4a995dfa52f8c4e4ed15694a5d1d77aa25102d29
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2023-11-04 14:53:13 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2023-11-04 15:00:51 +0000

    textproc/py-python-lsp-jsonrpc: Remove run_depends

    It turned out that some runtime dependencies are not necessary. These
    were probably relics from the search for necessary dependencies for the
    test target. Thanks to John Hein for the hint.

    PR:             274906
    MFH:            2023Q4
    (cherry picked from commit a721b47305eac2d636edea8102581fa9d9cc10c8)

 textproc/py-python-lsp-jsonrpc/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2023-11-04 15:05:09 UTC
I have rebuilt and installed the port in Poudriere without the three dependencies mentioned. The tests are running comparably, even the use via textproc/py-python-lsp-server seems to work as usual.


Therefore I have now committed a patch without these dependencies, in main and in quarterly. Many thanks for the hint!