Bug 274917 - textproc/cy-hunspell: Update to 20231031 version
Summary: textproc/cy-hunspell: Update to 20231031 version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ceri Davies
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-04 18:24 UTC by Ceri Davies
Modified: 2023-11-05 18:52 UTC (History)
1 user (show)

See Also:

Attachments
patch for new port (1.10 KB, patch)
2023-11-04 18:24 UTC, Ceri Davies 		no flags Details | Diff
improved patch (1.05 KB, patch)
2023-11-05 17:43 UTC, Ceri Davies 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ceri Davies freebsd_committer freebsd_triage 2023-11-04 18:24:37 UTC 
Created attachment 246121 [details]
patch for new port

A new release was committed.
Changes to Makefile and distinfo only.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-11-04 23:21:50 UTC 
Is there a particular reason why you don't use the release tags provided by upstream?
Comment 2 Ceri Davies freebsd_committer freebsd_triage 2023-11-04 23:30:08 UTC 
They aren't very consistent, also I did not really know that I could.
Happy to take guidance.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-11-04 23:33:47 UTC 
Ideally you'd just set DISTVERSION to the version used in upstreams tag such that ${DISTVERSIONPREFIX}${DISTVERSION}${DISTVERSIONSUFFIX} forms the name of upstreams tag.  Then remove GH_TAGNAME as it defaults to that.

I see that upstream's versioning is indeed inconsistent, but perhaps you can ask them to be more consistent.  Right now it should work to just put in

    DISTVERSION= 23.10

then remove GH_TAGNAME and regenerate distinfo.

See § 5.4.3 Porter's Handbook for more details.
Comment 4 Ceri Davies freebsd_committer freebsd_triage 2023-11-04 23:40:32 UTC 
Thanks, that’s really helpful; will sort tomorrow, much appreciated.
Comment 5 Ceri Davies freebsd_committer freebsd_triage 2023-11-05 17:43:50 UTC 
Created attachment 246142 [details]
improved patch

Changes as per fuz@
Comment 6 Ceri Davies freebsd_committer freebsd_triage 2023-11-05 17:44:13 UTC 
Have altered accordingly, thanks again.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-11-05 17:58:22 UTC 
LGTM for ports.
If it passes your testing, feel free to commit.
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-11-05 18:52:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c45f49322312d1544b07511eafd9bb7416a3a214

commit c45f49322312d1544b07511eafd9bb7416a3a214
Author:     Ceri Davies <ceri@FreeBSD.org>
AuthorDate: 2023-11-05 18:50:22 +0000
Commit:     Ceri Davies <ceri@FreeBSD.org>
CommitDate: 2023-11-05 18:50:22 +0000

    textproc/cy-hunspell: update to version 23.10

    PR:             274917
    Approved by:    fuz

 textproc/cy-hunspell/Makefile | 3 +--
 textproc/cy-hunspell/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)
Comment 9 Ceri Davies freebsd_committer freebsd_triage 2023-11-05 18:52:41 UTC 
Closing, thanks fuz@ for your help