Bug 274941 - sys.netinet6.frag6.frag6_19.frag6_19 is broken / unreliable
Summary: sys.netinet6.frag6.frag6_19.frag6_19 is broken / unreliable
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: 15.0-CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-testing (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-06 16:52 UTC by Warner Losh
Modified: 2023-11-08 13:11 UTC (History)
3 users (show)

See Also:


Attachments
Bring net.inet6.ip6.fraglifetime_ms back to 1 minute (630 bytes, patch)
2023-11-08 13:11 UTC, Jose Luis Duran
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Warner Losh freebsd_committer freebsd_triage 2023-11-06 16:52:28 UTC
sys.netinet6.frag6.frag6_19.frag6_19 needs to be marked expected fail to get us greeen again.

The error from the build log is
The failed test cases:
19:58:10 
19:58:10 1 tests failed.
19:58:10 FAILED:  sys.netinet6.frag6.frag6_19.frag6_19
19:58:10 
19:58:10 Error Message:
19:58:10 Global IPv6 statistics do not match: 19 != 20

It's been misbehaving for a long time.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-11-06 21:01:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=86e87c3bd1b377242aafe7e2222ae17ca0be96d9

commit 86e87c3bd1b377242aafe7e2222ae17ca0be96d9
Author:     Li-Wen Hsu <lwhsu@FreeBSD.org>
AuthorDate: 2023-11-06 20:59:24 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2023-11-06 20:59:24 +0000

    Skip sys.netinet6.frag6.frag6_19.frag6_19 in CI

    This test case is unreliable in CI environment.

    PR:             274941
    Sponsored by:   The FreeBSD Foundation

 tests/sys/netinet6/frag6/frag6_19.sh | 3 +++
 1 file changed, 3 insertions(+)
Comment 3 Bjoern A. Zeeb freebsd_committer freebsd_triage 2023-11-06 22:05:51 UTC
If this started recently, don't look at the test, look at the people who made changes that now make the test fail.
If it's always been the case (previously it was "long runtime but worked" to my knowledge) then let me know again.
Comment 4 Jose Luis Duran 2023-11-08 12:22:14 UTC
It's been failing for a while, since:

https://ci.freebsd.org/view/Test/job/FreeBSD-main-amd64-test/23655/testReport/sys.netinet6.frag6/frag6_19/frag6_19/

I have narrowed it down to:

<dropped-fragment-after-timeout>0</dropped-fragment-after-timeout>

Being the line that changes.  My money is on:

https://cgit.freebsd.org/src/commit/?id=e32221a15f089282e5dfe18891c5312b26cbe3ba
Comment 5 Jose Luis Duran 2023-11-08 13:11:15 UTC
Created attachment 246195 [details]
Bring net.inet6.ip6.fraglifetime_ms back to 1 minute

I have noticed that this stabilizes the test.
Let me just be clear that I do not fully understand test 19, so take it with a grain of salt.