Bug 275044 - Missing tab in `netstat -s` output
Summary: Missing tab in `netstat -s` output
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 14.0-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-12 17:43 UTC by sigsys
Modified: 2023-11-20 13:51 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sigsys 2023-11-12 17:43:50 UTC
This is really trivial, but visually annoying in the output.

diff --git a/usr.bin/netstat/inet6.c b/usr.bin/netstat/inet6.c
index b88e84ecc564..9141cca191ee 100644
--- a/usr.bin/netstat/inet6.c
+++ b/usr.bin/netstat/inet6.c
@@ -992,7 +992,7 @@ icmp6_stats(u_long off, const char *name, int af1 __unused, int proto __unused)
 	    "{N:/bad checksum%s}\n");
 	p(icp6s_badlen, "\t{:dropped-bad-length/%ju} "
 	    "{N:/message%s with bad length}\n");
-	p(icp6s_dropped, "{:dropped-no-entry/%ju} "
+	p(icp6s_dropped, "\t{:dropped-no-entry/%ju} "
 	    "{N:/total packet%s dropped due to failed NDP resolution}\n");
 #define	NELEM (int)(sizeof(icmp6stat.icp6s_inhist)/sizeof(icmp6stat.icp6s_inhist[0]))
 	for (first = 1, i = 0; i < NELEM; i++)
Comment 1 Kristof Provost freebsd_committer freebsd_triage 2023-11-12 18:17:40 UTC
Yep, I'll commit that.

Can you list the name you'd like to be credited as?
Comment 2 sigsys 2023-11-12 18:19:27 UTC
(In reply to Kristof Provost from comment #1)
Just my email (sigsys@gmail.com) is fine.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-12 18:25:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=4b5634f4e56ddc0554c5ebba610d45eb48b9210d

commit 4b5634f4e56ddc0554c5ebba610d45eb48b9210d
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2023-11-12 17:23:04 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2023-11-12 17:24:39 +0000

    netstat: fix missing tab in icmp6 output

    PR:             275044
    Submitted by:   sigsys@gmail.com
    Reviewed by:    kp
    MFC after:      1 week

 usr.bin/netstat/inet6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-11-19 19:30:38 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=4595a9e9af827db03b293a9aed72618bc285f54f

commit 4595a9e9af827db03b293a9aed72618bc285f54f
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2023-11-12 17:23:04 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2023-11-19 19:29:50 +0000

    netstat: fix missing tab in icmp6 output

    PR:             275044
    Submitted by:   sigsys@gmail.com
    Reviewed by:    kp
    MFC after:      1 week

    (cherry picked from commit 4b5634f4e56ddc0554c5ebba610d45eb48b9210d)

 usr.bin/netstat/inet6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-11-19 19:30:39 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=0a97a28c6c9f00997733bebd241403097f533404

commit 0a97a28c6c9f00997733bebd241403097f533404
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2023-11-12 17:23:04 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2023-11-19 19:29:44 +0000

    netstat: fix missing tab in icmp6 output

    PR:             275044
    Submitted by:   sigsys@gmail.com
    Reviewed by:    kp
    MFC after:      1 week

    (cherry picked from commit 4b5634f4e56ddc0554c5ebba610d45eb48b9210d)

 usr.bin/netstat/inet6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)