Bug 275151 - graphics/grafx2: Add message that procfs is required
Summary: graphics/grafx2: Add message that procfs is required
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-17 11:14 UTC by Tobias Rehbein
Modified: 2023-11-17 16:41 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
Patch to add pkg-message to graphics/grafx2 (474 bytes, patch)
2023-11-17 11:19 UTC, Tobias Rehbein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Rehbein 2023-11-17 11:14:01 UTC

    
Comment 1 Tobias Rehbein 2023-11-17 11:19:56 UTC
Created attachment 246372 [details]
Patch to add pkg-message to graphics/grafx2

GrafX2 require procfs(5) to be mounted. Otherwise it may fail to find its data directory. I propose a patch to show a message, documenting this requirement, at install time.

Background: The requirement is caused by the setting of SELF_PATH to "/proc/curproc/file" in setup.c (https://gitlab.com/GrafX2/grafX2/-/blob/master/src/setup.c?ref_type=heads#L104)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-17 16:40:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c8961191accdc63e1308fce416f17514f4db1897

commit c8961191accdc63e1308fce416f17514f4db1897
Author:     Tobias Rehbein <tobias.rehbein@web.de>
AuthorDate: 2023-11-17 16:38:57 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2023-11-17 16:38:57 +0000

    graphics/grafx2: Add message that procfs is required

    PR:             275151

 graphics/grafx2/Makefile          |  2 +-
 graphics/grafx2/pkg-message (new) | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-17 16:40:26 UTC
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c3a4b195360f0e395568416c24fa30fe685a5b13

commit c3a4b195360f0e395568416c24fa30fe685a5b13
Author:     Tobias Rehbein <tobias.rehbein@web.de>
AuthorDate: 2023-11-17 16:38:57 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2023-11-17 16:40:03 +0000

    graphics/grafx2: Add message that procfs is required

    PR:             275151
    (cherry picked from commit c8961191accdc63e1308fce416f17514f4db1897)

 graphics/grafx2/Makefile          |  2 +-
 graphics/grafx2/pkg-message (new) | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)
Comment 4 Emanuel Haupt freebsd_committer freebsd_triage 2023-11-17 16:41:45 UTC
Committed, thanks!