Bug 275349 - audio/alsa-utils: aplaymidi doesn't play at the proper tempo
Summary: audio/alsa-utils: aplaymidi doesn't play at the proper tempo
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-26 09:48 UTC by Tatsuki Makino
Modified: 2023-11-29 21:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rodrigo)


Attachments
patch that should fix the problem for audio/alsa-utils (707 bytes, patch)
2023-11-26 09:48 UTC, Tatsuki Makino
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2023-11-26 09:48:14 UTC
Created attachment 246577 [details]
patch that should fix the problem for audio/alsa-utils

aplaymidi does not process tempo events because the part that handles tempo events was not rewritten sufficiently.
It may be executed as a different event in songs that have tempo changes in the middle of the song.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-11-29 21:07:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f05f058867c8cba577ff6c6f90631e9940e947db

commit f05f058867c8cba577ff6c6f90631e9940e947db
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2023-11-29 20:44:12 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2023-11-29 21:07:13 +0000

    audio/alsa-utils: aplaymidi doesn't play at the proper tempo

    Add temporary patch to fix an issue with tempo events

    aplaymidi does not process tempo events because the part
    that handles tempo events was not rewritten sufficiently.
    It may be executed as a different event in songs that
    have tempo changes in the middle of the song.

    A similar fix was submitted to upstream as
    https://github.com/alsa-project/alsa-utils/issues/241

    PR:             275349
    Reported by:    Tatsuki Makino <tatsuki_makino@hotmail.com>

 audio/alsa-utils/Makefile                                    |  1 +
 audio/alsa-utils/files/patch-seq_aplaymidi_aplaymidi.c (new) | 11 +++++++++++
 2 files changed, 12 insertions(+)
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2023-11-29 21:12:02 UTC
Hi,
Thanks for this fix, as said in the commit message a similar fix
was submitted upstream so hopefully aplaymidi will be fixed in
next release.

Cheers
-- rodrigo