Bug 275403 - audio/libbs2b: Don't clip floating point samples
Summary: audio/libbs2b: Don't clip floating point samples
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-28 08:28 UTC by Daniel Engberg
Modified: 2023-12-17 20:13 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (liangtai.s16)


Attachments
Patch for libbs2b (1.17 KB, patch)
2023-11-28 08:28 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-11-28 08:28:55 UTC
Created attachment 246631 [details]
Patch for libbs2b

Import patch to disable clipping of floating point samples

While at it, return port to pool as maintainer hasn't replied to any other port related requests for a long time.

Reference:
https://github.com/strawberrymusicplayer/strawberry/issues/1320
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-12-17 19:05:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b9a34290c5ce02678b4cd0868cb53799e72e7458

commit b9a34290c5ce02678b4cd0868cb53799e72e7458
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-12-16 15:33:16 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-12-17 19:04:30 +0000

    audio/libbs2b: Don't clip floating point samples

    Disable clamping as it causes incorrect behaviour
    While at it return port to pool as maintainer hasn't responded on
    multiple bug reports.

    Reference:
    https://github.com/strawberrymusicplayer/strawberry/issues/1320

    Source:
    https://github.com/alexmarsev/libbs2b/commit/5ca2d59888df047f1e4b028e3a2fd5be8b5a7277

    PR:             275403
    Approved by:    portmgr (maintainer timeout, 2+ weeks)

 audio/libbs2b/Makefile | 11 +++++++----
 audio/libbs2b/distinfo |  3 +++
 2 files changed, 10 insertions(+), 4 deletions(-)