Bug 275495 - graphics/qgis turn off qt5-webkit now that py-qt5-pyqt no longer uses it
Summary: graphics/qgis turn off qt5-webkit now that py-qt5-pyqt no longer uses it
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-03 08:01 UTC by alt2600
Modified: 2023-12-03 15:08 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rhurlin)


Attachments
Makefile_disable_webkit.diff (647 bytes, patch)
2023-12-03 08:01 UTC, alt2600
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description alt2600 2023-12-03 08:01:16 UTC
Created attachment 246737 [details]
Makefile_disable_webkit.diff

so noticed a little glitch when I finally was able to delete qt5-webkit after py-qt5-pyqt removed it. qgis was still silently needing it, but it likely wasn't causing issues with the package builders because qt5-webkit was still in the build because of py39-qt5-pyqt still having the dependency. So I added the bool variable to the CMAKE_ARGS string in the Makefile to turn off the optional dependency as it wouldn't configure otherwise.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-12-03 14:59:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0cbe960ed539b3108c02ea9eb974119f2e837599

commit 0cbe960ed539b3108c02ea9eb974119f2e837599
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2023-12-03 14:50:06 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2023-12-03 14:59:02 +0000

    graphics/qgis: Really disable usage of qtwebkit

    While here, pet portlint.

    Co-authored-by: alt2600@icloud.com

    PR:             275495

 graphics/qgis/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-12-03 15:05:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=87e4ed524108db29f81c6ec8c2d3d095cdbdc8d9

commit 87e4ed524108db29f81c6ec8c2d3d095cdbdc8d9
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2023-12-03 15:03:45 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2023-12-03 15:05:06 +0000

    graphics/qgis-ltr: Really disable usage of qtwebkit

    While here, pet portlint.

    Co-authored-by: alt2600@icloud.com

    PR:             275495

 graphics/qgis-ltr/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2023-12-03 15:08:31 UTC
Hi alt2600@icloud.com,
Many thanks for the hint. I forgot about it some time ago, now it is back thanks to you :)

Committed to both, qgis and qgis-ltr.