Bug 275532 - science/elmerfem: Fix Qt dependencies
Summary: science/elmerfem: Fix Qt dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Henrik Gulbrandsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-04 18:55 UTC by Jason E. Hale
Modified: 2023-12-04 22:42 UTC (History)
1 user (show)

See Also:
henrik: maintainer-feedback+

Attachments
v1 (1.54 KB, patch)
2023-12-04 18:55 UTC, Jason E. Hale 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale freebsd_committer freebsd_triage 2023-12-04 18:55:36 UTC 
Created attachment 246779 [details]
v1

Drop unused Qt dependencies. This port does not need the Qt5 WebKit module. There is no reference to it anywhere in the code. Remove DEPRECATED/EXPIRATION_DATE.
Comment 1 Henrik Gulbrandsen 2023-12-04 20:57:06 UTC 
(In reply to Jason E. Hale from comment #0)

You are right. Qt5 WebKit must have been an indirect dependency dragged in by the obsolete math/vtk6 port when we added ElmerGUI support back in 2020.

Feel free to commit.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-12-04 22:40:17 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8905cb6ecee3027cba5dd41996617f6c76bbf1c0

commit 8905cb6ecee3027cba5dd41996617f6c76bbf1c0
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2023-12-03 19:56:17 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-12-04 22:39:28 +0000

    science/elmerfem: Drop unused Qt5 deps

    Remove DEPRECATED/EXPIRATION_DATE. This port does not need the
    deprecated Qt5 WebKit module. There is no reference to it anywhere in
    the code.

    Maintainer reckons these were leftover indirect dependencies from
    math/vtk6.

    PR:             275532
    Approved by:    Henrik Gulbrandsen <henrik@gulbra.net> (maintainer)

 science/elmerfem/Makefile | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2023-12-04 22:42:08 UTC 
Thank you for the quick response! science/elmerfem lives on!