Bug 275691 - NanoBSD build broken due to wrong fix
Summary: NanoBSD build broken due to wrong fix
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 14.0-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: Gleb Smirnoff
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2023-12-11 11:15 UTC by Wout Decré
Modified: 2024-01-02 19:05 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wout Decré 2023-12-11 11:15:50 UTC 
d8c70d6dfb65 fixes a typo that was introduced in cbf64e2dd59c but creates a wrong value for NANO_OBJ.

The fix adds an extra } after the first NANO_LAYOUT but this should have been added at the end like so:

: ${NANO_OBJ:=/usr/obj/nanobsd.${NANO_NAME}${NANO_LAYOUT:+.${NANO_LAYOUT}}}

Otherwise, NANO_OBJ will be:

/usr/obj/nanobsd.NANO_NAMENANO_LAYOUT:+.NANO_LAYOUT
or
/usr/obj/nanobsd.NANO_NAME:+.

instead of:

/usr/obj/nanobsd.NANO_NAME.NANO_LAYOUT
or
/usr/obj/nanobsd.NANO_NAME
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2023-12-11 14:32:02 UTC 
^Triage: assign to committer of d8c70d6dfb65.
Comment 2 Jose Luis Duran freebsd_committer freebsd_triage 2023-12-13 16:29:58 UTC 
https://reviews.freebsd.org/D43035
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-12-21 18:15:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=330089470f56d502c629352b85e11522691e3368

commit 330089470f56d502c629352b85e11522691e3368
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2023-12-21 18:13:44 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2023-12-21 18:13:44 +0000

    nanobsd: Fix the fix to a typo

    Submitted by:           jlduran@gmail.com
    Reviewed by:            imp, glebius, emaste
    PR:                     275691
    Differential Revision:  https://reviews.freebsd.org/D43035
    Fixes:                  d8c70d6dfb65218dd3272b34512083621d3ed46d

 tools/tools/nanobsd/defaults.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Gleb Smirnoff freebsd_committer freebsd_triage 2023-12-21 18:16:53 UTC 
Committed to CURRENT. Thanks!
Comment 5 Gleb Smirnoff freebsd_committer freebsd_triage 2023-12-21 22:57:43 UTC 
qwerqwe
Comment 6 Gleb Smirnoff freebsd_committer freebsd_triage 2023-12-21 23:02:33 UTC 
qwerqwe
Comment 7 Gleb Smirnoff freebsd_committer freebsd_triage 2023-12-21 23:09:07 UTC 
foo bar
Comment 8 Gleb Smirnoff freebsd_committer freebsd_triage 2023-12-21 23:17:08 UTC 
foo bar
Comment 9 Gleb Smirnoff freebsd_committer freebsd_triage 2023-12-21 23:37:12 UTC 
Sorry for the spam, was testing a script to interact with Bugzilla.
Comment 10 Gleb Smirnoff freebsd_committer freebsd_triage 2023-12-21 23:45:45 UTC 
Sorry for the spam, was testing a script to interact with Bugzilla.
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-01-02 19:05:53 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=98bac6fb064ca7536ddb67b845c653b926b699a5

commit 98bac6fb064ca7536ddb67b845c653b926b699a5
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2023-12-21 18:13:44 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2024-01-02 19:05:08 +0000

    nanobsd: Fix the fix to a typo

    Submitted by:           jlduran@gmail.com
    Reviewed by:            imp, glebius, emaste
    PR:                     275691
    Differential Revision:  https://reviews.freebsd.org/D43035
    Fixes:                  d8c70d6dfb65218dd3272b34512083621d3ed46d

    (cherry picked from commit 330089470f56d502c629352b85e11522691e3368)

 tools/tools/nanobsd/defaults.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)