Bug 276028 - net-im/toot: update to 0.40.2
Summary: net-im/toot: update to 0.40.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-30 21:32 UTC by Lexi Winter
Modified: 2024-01-14 21:01 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (0mp)


Attachments
patch (1.72 KB, patch)
2023-12-30 21:32 UTC, Lexi Winter
no flags Details | Diff
0.41.1 patch (1.72 KB, patch)
2024-01-05 14:54 UTC, Lexi Winter
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lexi Winter 2023-12-30 21:32:20 UTC
Created attachment 247364 [details]
patch

the app is broken after this update, but it was already broken before this update, because of bug 274411 which broke urwid.  the new version works fine if urwid is fixed locally (e.g. by installing devel/py-setuptools_scm7 instead of devel/py-setuptools_scm).
Comment 1 Lexi Winter 2024-01-05 14:54:48 UTC
Created attachment 247461 [details]
0.41.1 patch

new patch: 0.41.1 is released
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-01-14 11:08:05 UTC
Cool, thanks for the patch!

Would you like to become the maintainer of this port?
Comment 3 Lexi Winter 2024-01-14 19:52:15 UTC
i'd be happy to maintain this, since i use it and also work on the upstream code.

do you want a patch to change MAINTAINER?  i can have a look at adding a patch for the urwid issue at the same time.
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-01-14 19:56:48 UTC
Amazing!

You may submit another patches if you wish, but I don't think that is necessary in this case. I just need to know what email address I should assign  net-im/toot and devel/py-urwid-readline to :)
Comment 5 Lexi Winter 2024-01-14 20:43:43 UTC
this address (lexi.freebsd@le-fay.org) is fine for net-im/toot.

i don't think i want to maintain devel/py-urwid-readline - i don't use that myself and toot doesn't depend on it, so i probably wouldn't be a very good person to maintain it :-)
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-01-14 20:47:44 UTC
Alright then :) I thought that you were referring to devel/py-urwid-readline when you mentioned urwird earlier. I double checked now and it seems like that devel/py-urwid-readline has nothing to do with toot. It is a dependency of another CLI I was porting around the same time: net-im/scli. Sorry for the confusion.

I'll commit net-im/toot changes in a moment.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-01-14 20:59:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f68d4c2e456f0ff3695fd9fa2cca71a2eaa68496

commit f68d4c2e456f0ff3695fd9fa2cca71a2eaa68496
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-01-14 20:50:05 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-01-14 20:51:00 +0000

    net-im/toot: Pass maintainership

    PR:             276028

 net-im/toot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-01-14 20:59:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d4df43b0bd2cb9dcc35f870b022c72d68a6cddf0

commit d4df43b0bd2cb9dcc35f870b022c72d68a6cddf0
Author:     Lexi Winter <lexi@le-Fay.ORG>
AuthorDate: 2023-12-30 21:26:27 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-01-14 20:50:59 +0000

    net-im/toot: Update to 0.41.1

    PR:             276028
    Approved by:    maintainer

 net-im/toot/Makefile | 4 +++-
 net-im/toot/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 4 deletions(-)
Comment 9 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-01-14 21:01:45 UTC
Thanks!