Bug 276034 - www/yt-dlp: missing man page
Summary: www/yt-dlp: missing man page
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-31 09:55 UTC by Benjamin Takacs
Modified: 2023-12-31 18:53 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Takacs 2023-12-31 09:55:58 UTC 
yt-dlp is missing its man page

The upstream Makefiles install target depends on yt-dlp.1 [0], so no idea why missing pandoc to build the man page doesn't cause problems

[0]: https://github.com/yt-dlp/yt-dlp/blob/9f40cd289665b2fb8a05ccaf9721b3b2ca0f39c7/Makefile#L47
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-12-31 10:08:57 UTC 
Fixed.

Thanks for your report!
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-12-31 10:09:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7b635e97fb02804ca3486b2ec9dde8762c4cbd48

commit 7b635e97fb02804ca3486b2ec9dde8762c4cbd48
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-12-31 10:07:35 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-12-31 10:09:08 +0000

    www/yt-dlp: Install manpage

    PR:             276034
    Reported by:    Benjamin Takacs <nimaje+fbz@bureaucracy.de>

 www/yt-dlp/Makefile             |  4 +++-
 www/yt-dlp/files/patch-Makefile | 15 ++-------------
 www/yt-dlp/pkg-plist            |  1 +
 3 files changed, 6 insertions(+), 14 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-12-31 12:24:23 UTC 
Please don't make pandoc a hard build dependency
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2023-12-31 18:09:43 UTC 
(In reply to Daniel Engberg from comment #3)

Hi Daniel.


I agree with you.

I've added the suggestion for the upstream to have the manpage in the repository: https://github.com/yt-dlp/yt-dlp/issues/8897

Let's see what they say.


Thanks,
Yuri
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-12-31 18:53:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=75efa01f5ee3f492f37e32d806d4e3f910bbf228

commit 75efa01f5ee3f492f37e32d806d4e3f910bbf228
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-12-31 18:51:20 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-12-31 18:51:20 +0000

    www/yt-dlp: Remove the pandoc dependency

    PR:             276034
    Reported by:    vvd@, diizzy@

 www/yt-dlp/Makefile             |  3 +--
 www/yt-dlp/files/patch-Makefile | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 2 deletions(-)