Bug 276166 - security/keybase update to 6.2.4
Summary: security/keybase update to 6.2.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-07 03:15 UTC by J Adams
Modified: 2024-02-12 16:53 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description J Adams 2024-01-07 03:15:39 UTC
The Keybase version currently in Ports, 6.2.3_1, no longer functions as of 1 January 2024 due to the API certificate expiring. Version 6.2.4, released 2 January 2024 fixes this issue:
https://github.com/keybase/client/releases/tag/v6.2.4
and the actual certificate commit:
https://github.com/keybase/client/commit/fbebbc9f1ba29e21ae6d3ee2edc21a7703d0019f
Comment 1 J Adams 2024-01-17 23:49:48 UTC
Please let me know if there is anything I can do to help, of if there is any more information I could provide. Thanks!
Comment 2 Pietro Cerutti freebsd_committer freebsd_triage 2024-02-11 08:35:59 UTC
Ping?
Comment 3 J Adams 2024-02-11 12:43:12 UTC
(In reply to Pietro Cerutti from comment #2)
 Hi there Pietro! I've compiled 6.2.4 successfully and dropped the `keybase` binary in to /usr/local/bin/. This, of course causes the periodic daily run to complain about mismatched checksums. It works, but it's definitely a stop-gap solution. The build does not produce kbfsfuse or kbfstool binaries; I don't yet know how to do that. I would like to learn the whole process for building the whole package.
Comment 4 Pietro Cerutti freebsd_committer freebsd_triage 2024-02-12 08:13:38 UTC
Yup, the ping was for sunpoet@. Here's a patch that works for me:

diff --git a/security/keybase/Makefile b/security/keybase/Makefile
index 86d187c5a9d6..02a40171433b 100644
--- a/security/keybase/Makefile
+++ b/security/keybase/Makefile
@@ -1,5 +1,5 @@
 PORTNAME=      keybase
-PORTVERSION=   6.2.3
+PORTVERSION=   6.2.4
 PORTREVISION=  1
 DISTVERSIONPREFIX=     v
 MASTER_SITES=  https://raw.githubusercontent.com/keybase/client/v${PORTVERSION}/go/:gomod
diff --git a/security/keybase/distinfo b/security/keybase/distinfo
index 0422edcac6f2..e5420115ae86 100644
--- a/security/keybase/distinfo
+++ b/security/keybase/distinfo
@@ -1,5 +1,5 @@
-TIMESTAMP = 1698340931
-SHA256 (go/security_keybase/keybase-client-v6.2.3_GH0/go.mod) = 5f49a7aaa6c482e9ca9bd1b3bd6147a78f50edd8171b4bbf513cf2e3830e4183
-SIZE (go/security_keybase/keybase-client-v6.2.3_GH0/go.mod) = 18668
-SHA256 (go/security_keybase/keybase-client-v6.2.3_GH0/keybase-client-v6.2.3_GH0.tar.gz) = f84b857c3ad21de5e3c6c7c9f71f6c56a33565f3136393f3fb8c8ca49f42f987
-SIZE (go/security_keybase/keybase-client-v6.2.3_GH0/keybase-client-v6.2.3_GH0.tar.gz) = 53208406
+TIMESTAMP = 1707645235
+SHA256 (go/security_keybase/keybase-client-v6.2.4_GH0/go.mod) = 5f49a7aaa6c482e9ca9bd1b3bd6147a78f50edd8171b4bbf513cf2e3830e4183
+SIZE (go/security_keybase/keybase-client-v6.2.4_GH0/go.mod) = 18668
+SHA256 (go/security_keybase/keybase-client-v6.2.4_GH0/keybase-client-v6.2.4_GH0.tar.gz) = a9b2c938b14ac3deb92532047a8e69eb37b37ad0d6bf996ee979a9be3f15a834
+SIZE (go/security_keybase/keybase-client-v6.2.4_GH0/keybase-client-v6.2.4_GH0.tar.gz) = 53209004
Comment 5 J Adams 2024-02-12 14:34:39 UTC
(In reply to Pietro Cerutti from comment #4)
I assumed you were pinging sunpoet@; thanks for the patch.
Comment 6 J Adams 2024-02-12 15:49:11 UTC
(In reply to Pietro Cerutti from comment #4)
Patch applied, port build and installed. New version works as expected. The one minor snag was that `patch` initially failed to patch Makefile; succeeded on distinfo however.  

Relevant output:  
# patch -i keybase.patch 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|diff --git a/security/keybase/Makefile b/security/keybase/Makefile
|index 86d187c5a9d6..02a40171433b 100644
|--- a/security/keybase/Makefile
|+++ b/security/keybase/Makefile
--------------------------
Patching file Makefile using Plan A...
Hunk #1 failed at 1.
1 out of 1 hunks failed--saving rejects to Makefile.rej

Easily worked around as it was a one-line edit:
# cat Makefile.rej
@@ -1,5 +1,5 @@
 PORTNAME=      keybase
-PORTVERSION=   6.2.3
+PORTVERSION=   6.2.4
 PORTREVISION=  1
 DISTVERSIONPREFIX=     v
 MASTER_SITES=  https://raw.githubusercontent.com/keybase/client/v${PORTVERSION}/go/:gomod
Comment 7 Pietro Cerutti freebsd_committer freebsd_triage 2024-02-12 16:11:21 UTC
Yep, this commit has bumped PORTREVISION:
https://cgit.freebsd.org/ports/commit/?id=7e5aa2085f48d71be003c8ff0377bde837467291
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-02-12 16:52:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6debf4e0091540db110fc7b8d37f2943f317c039

commit 6debf4e0091540db110fc7b8d37f2943f317c039
Author:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2024-02-12 16:51:22 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
CommitDate: 2024-02-12 16:52:21 +0000

    security/keybase: update to 6.2.4

    PR:             276166
    Approved by:    maintainer (timeout)

 security/keybase/Makefile |  6 +++---
 security/keybase/distinfo | 10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)