Bug 276370 - x11/idesk: Fix build with graphics/imlib2 1.12.1
Summary: x11/idesk: Fix build with graphics/imlib2 1.12.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks: 276369
  Show dependency tree / graph
 
Reported: 2024-01-16 10:07 UTC by Nuno Teixeira
Modified: 2024-01-18 22:08 UTC (History)
1 user (show)

See Also:

Attachments
Fix build with imlib2 1.12.1 (5.50 KB, patch)
2024-01-16 10:07 UTC, Nuno Teixeira 		acm: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2024-01-16 10:07:03 UTC 
Created attachment 247696 [details]
Fix build with imlib2 1.12.1

- Fix build with imlib2 1.12.1 due to imlib2-config drop in 1.7.5
  in favor of pkgconfig
- Fix SN option build (lib depends)
- Add license

Sugestion:
- Pet portlint, portclippy, portfmt and Q/A check

NOTES:

https://github.com/neagix/idesk fork is at 0.7.8 and is used by some linux distros. Maybe this could be checked for a further update.
Comment 1 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-01-16 14:15:13 UTC 
Comment on attachment 247696 [details]
Fix build with imlib2 1.12.1

Approved!
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2024-01-16 14:18:29 UTC 
(In reply to Jose Alonso Cardenas Marquez from comment #1)
Nice :)

What you think about fork or updating to it?
Comment 3 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-01-16 15:06:50 UTC 
it is ok for me use idesk fork if it is better. Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-01-18 22:07:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ff4bc28d1eb9df3c651af62568bd848fa59c0f67

commit ff4bc28d1eb9df3c651af62568bd848fa59c0f67
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2024-01-18 22:05:42 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-01-18 22:05:42 +0000

    x11/idesk: Fix build with graphics/imlib2 1.12.1

    - Fix build with imlib2 1.12.1 due to imlib2-config drop in 1.7.5
      in favor of pkgconfig
    - Fix SN option build (lib depends)
    - Add license
    - Pet portlint, portclippy, portfmt and Q/A check

    PR:             276370

 x11/idesk/Makefile                              | 32 +++++++++++++++----------
 x11/idesk/files/patch-configure (new)           | 32 +++++++++++++++++++++++++
 x11/idesk/files/patch-src_DesktopConfig.cpp     | 26 ++++++++------------
 x11/idesk/files/patch-src_Timer.cpp             |  4 ++--
 x11/idesk/files/patch-src_XImlib2Background.cpp | 26 ++++++++------------
 5 files changed, 74 insertions(+), 46 deletions(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2024-01-18 22:08:15 UTC 
Committed, thanks!