Bug 276473 - graphics/imlib2: enable JPEG XL by default
Summary: graphics/imlib2: enable JPEG XL by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on: 276369
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-20 15:53 UTC by Jan Beich
Modified: 2024-01-20 16:17 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (eduardo)


Attachments
v1 (apply via "git am") (2.53 KB, patch)
2024-01-20 15:53 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2024-01-20 15:53:36 UTC
Created attachment 247797 [details]
v1 (apply via "git am")

Already default upstream via auto-detection e.g.,

$ pkg install libjxl
$ export DEVELOPER=1 || setenv DEVELOPER 1
$ make clean all -C graphics/imlib2
[...]
====> Running Q/A tests (stage-qa)
Error: /usr/local/lib/imlib2/loaders/jxl.so is linked to /usr/local/lib/libjxl.so.0.9 from graphics/libjxl but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libjxl.so:graphics/libjxl
Error: /usr/local/lib/imlib2/loaders/jxl.so is linked to /usr/local/lib/libjxl_threads.so.0.9 from graphics/libjxl but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libjxl_threads.so:graphics/libjxl
Comment 1 Jan Beich freebsd_committer freebsd_triage 2024-01-20 16:07:26 UTC
On landing PORTREVISION must be bumped. I don't want to reupload the diff for such a minor change.

imlib2/WEBP=on vs. imlib2-webp and imlib2/JXL=on vs. imlib2-jxl can be improved via SUBPACKAGES. Alternatively, imlib2-webp and imlib2-jxl can be removed from ports/ tree.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-01-20 16:13:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6c7466cb7f3c9d5e52f356847bf0ee8cbb619252

commit 6c7466cb7f3c9d5e52f356847bf0ee8cbb619252
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-01-20 16:09:48 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-01-20 16:09:48 +0000

    graphics/imlib2: enable JPEG XL by default

    Already default upstream via auto-detection.
    Adjust conflicts per options.

    PR:             276473

 graphics/imlib2/Makefile  | 12 ++++++++----
 graphics/imlib2/pkg-plist |  1 +
 2 files changed, 9 insertions(+), 4 deletions(-)
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2024-01-20 16:17:24 UTC
(In reply to Jan Beich from comment #1)

Nice catch.

SUBPACKAGES have been discussed on element chat. Will work on it and open a review soon.

Committed, thank you!