Bug 276494 - deskutils/py-todoman: Update to 4.4.0
Summary: deskutils/py-todoman: Update to 4.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://github.com/pimutils/todoman/b...
Keywords:
Depends on: 274411
Blocks:
  Show dependency tree / graph
 
Reported: 2024-01-21 11:59 UTC by Andreas Bilke
Modified: 2024-06-30 06:05 UTC (History)
1 user (show)

See Also:

Attachments
Update to 4.4.0 (1.72 KB, patch)
2024-01-21 11:59 UTC, Andreas Bilke 		andreas: maintainer-approval+
Details | Diff
Update to 4.4.0 (1.70 KB, patch)
2024-06-09 19:20 UTC, Andreas Bilke 		andreas: maintainer-approval+
Details | Diff
Add pytest and TEST_DEPENDS (2.64 KB, patch)
2024-06-18 18:46 UTC, Zsolt Udvari 		uzsolt: maintainer-approval?
Details | Diff
Update to 4.4.0 (2.62 KB, patch)
2024-06-29 19:24 UTC, Andreas Bilke 		andreas: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Bilke 2024-01-21 11:59:00 UTC 
Created attachment 247815 [details]
Update to 4.4.0

- Update to the latest upstream version
- Switch to PEP517 build

Please note that running todoman will result in a crash because of the bug in 274411
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-06-06 18:49:10 UTC 
error: patch failed: deskutils/py-todoman/Makefile:1
error: deskutils/py-todoman/Makefile: patch does not apply

Could you please update the patch?
Comment 2 Andreas Bilke 2024-06-09 19:20:31 UTC 
Created attachment 251328 [details]
Update to 4.4.0

(In reply to Zsolt Udvari from comment #1)

The patch should apply now. Thanks for noticing.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-06-18 18:46:29 UTC 
Created attachment 251547 [details]
Add pytest and TEST_DEPENDS

Rearranged dependencies as portfmt suggests.
Add pytest and TEST_DEPENDS to run 'make test'

But the 'make test' doesn't run successful, throw an error:
>           assert "CREATED:20170831T234953Z\n" in f.readlines()
E           AssertionError: assert 'CREATED:20170831T234953Z\n' in ['BEGIN:VCALENDAR\n', 'VERSION:2.0\n', 'PRODID:io.barrera.todoman\n', 'BEGIN:VTODO\n', 'CREATED;VALU
E=DATE-TIME:20170831T234953Z\n', 'DTSTAMP;VALUE=DATE-TIME:20240618T183340Z\n', ...]
E            +  where ['BEGIN:VCALENDAR\n', 'VERSION:2.0\n', 'PRODID:io.barrera.todoman\n', 'BEGIN:VTODO\n', 'CREATED;VALUE=DATE-TIME:20170831T234953Z\n', 'DTSTAMP;VAL
UE=DATE-TIME:20240618T183340Z\n', ...] = <built-in method readlines of _io.TextIOWrapper object at 0x8eb5ba253c0>()
E            +    where <built-in method readlines of _io.TextIOWrapper object at 0x8eb5ba253c0> = <_io.TextIOWrapper name='/tmp/pytest-of-root/pytest-0/test_datetime_
serialization0/default/5526374af3df4a01b4df44c8be1bd5ce@13-default.ics' mode='r' encoding='utf-8'>.readlines

tests/test_backend.py:21: AssertionError


Could you please check?
Comment 4 Andreas Bilke 2024-06-29 19:24:41 UTC 
Created attachment 251781 [details]
Update to 4.4.0

Thank you for noticing. I moved one dep from test to build (since it was no test dependency).

I can reproduce your failing test within poudriere system. But cannot reproduce it otherwise in the way todoman tests their stuff in CI.

It is probably some dependency version thing (like we use some old python deps here).

Is it okay for you if I ignore this one failing test (see Makefile)?
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-06-30 06:04:59 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b206a6222c466194ed25c2c0b6e72ad0584a8617

commit b206a6222c466194ed25c2c0b6e72ad0584a8617
Author:     Andreas Bilke <andreas@bilke.org>
AuthorDate: 2024-06-30 05:57:17 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-06-30 06:03:16 +0000

    deskutils/py-todoman: Update to 4.4.0

    Add USES=pytest and TEST_DEPENDS.
    Ignore test_datetime_serialization test: fails in poudriere system but
    does not fail otherwise.

    Changelog: https://github.com/pimutils/todoman/blob/v4.4.0/CHANGELOG.rst

    PR:             276494
    Approved by:    Submitter is maintainer

 deskutils/py-todoman/Makefile | 21 ++++++++++++++-------
 deskutils/py-todoman/distinfo |  6 +++---
 2 files changed, 17 insertions(+), 10 deletions(-)
Comment 6 Zsolt Udvari freebsd_committer freebsd_triage 2024-06-30 06:05:27 UTC 
(In reply to Andreas Bilke from comment #4)
Yes, okay.

Committed, thanks!