Created attachment 247878 [details] Remove MANPREFIX All of the ports related to MANPREFIX has been fixed and it's time to remove this from Mk as the first step to switch to ${PREFIX}/share/man. Let's run an exp-run before the removal. Although it might seem that we are removing NOOP codes but this will at least prevent users from adding it again while we are migrating the paths to ${PREFIX}/share.
-GNU_CONFIGURE_MANPREFIX?= ${PREFIX} +GNU_CONFIGURE_MANPREFIX?= ${PREFIX}/share -MANDIRS+= ${PREFIX}/man +MANDIRS+= ${PREFIX}/share/man on next step?
Ignore question about MANDIRS.
(In reply to Vladimir Druzenko from comment #1) Yes, this work is being done here: https://github.com/arrowd/freebsd-ports/tree/autotools-mandir
(In reply to Vladimir Druzenko from comment #1) You are talking about chapter 2. Which is still to come at a later stage. We could do it later in one go. But you know we are stupid and someone will eventually add this again while we are busy with chapter 2. So let's not let others add it again. 3:)
Hi Antoine, Have you been able to run this exp-run?
New failure logs: https://pkg-status.freebsd.org/package18/data/140amd64-default-foo/2024-01-24_10h42m25s/logs/errors/xmake-1.06_2.log https://pkg-status.freebsd.org/package18/data/140amd64-default-foo/2024-01-24_10h42m25s/logs/errors/rbot-20160325_1,1.log https://pkg-status.freebsd.org/package18/data/140amd64-default-foo/2024-01-24_10h42m25s/logs/errors/countrycodes-1.0.6_1.log https://pkg-status.freebsd.org/package18/data/140amd64-default-foo/2024-01-24_10h42m25s/logs/errors/fence-agents-4.12.1.log https://pkg-status.freebsd.org/package18/data/140amd64-default-foo/2024-01-24_10h42m25s/logs/errors/ttcp-1.12_3.log
Some were fixed in between this ticket and the end of the exp-run and some were fixed in my latest push. Can you run this once more please?
(In reply to Muhammad Moinur Rahman from comment #7) Sorry, but this kind of exp-run takes 1 week to complete. Please test the few ports yourself.
I have tested these 5 locally after the commits. Which are building fine. So are you saying that if these 5 builds fine locally with the patch I can go ahead with this commit?
(In reply to Muhammad Moinur Rahman from comment #9) yes
Thanks.
Created attachment 248067 [details] patch against benchmarks/ttcp (fix MANPREFIX) This pets pkg-fallout@ for benchmarks/ttcp. Hope this helps! --Chris
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8f80d6dde15c23f550d7f2201299c04e49d91ecc commit 8f80d6dde15c23f550d7f2201299c04e49d91ecc Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> AuthorDate: 2024-01-29 20:53:06 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2024-01-29 22:25:54 +0000 Mk/bsd.port.mk: Sunset MANPREFIX For historical reasons FreeBSD had been using PREFIX/man to install man pages and a variable MANPREFIX was utilized to do this. While the rest of the UNIX/Linux world had been mostly using PREFIX/share. As the first step of moving to PREFIX/share/man this commit removes all the references to the MANPREFIX variable. Apart from MAKE_ARGS this variable no longer exists and should not be used to refer to PREFIX anymore in the future. The entire shift to PREFIX/share/man will take some more times as there are around 4000 ports which installs man page to PREFIX/man. PR: 276551 Approved by: portmgr (exp-run) Mk/bsd.port.mk | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-)