Bug 276561 - sysutils/lsblk: update to 3.8
Summary: sysutils/lsblk: update to 3.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-23 18:06 UTC by Slawomir Wojciech Wojtczak
Modified: 2024-01-27 20:45 UTC (History)
1 user (show)

See Also:


Attachments
lsblk.diff (BROKEN) (796 bytes, text/plain)
2024-01-23 18:06 UTC, Slawomir Wojciech Wojtczak
no flags Details
lsblk.diff (796 bytes, text/plain)
2024-01-24 09:12 UTC, Slawomir Wojciech Wojtczak
no flags Details
lsblk.diff - THIS ONE WORKS (813 bytes, patch)
2024-01-27 16:48 UTC, Slawomir Wojciech Wojtczak
vermaden: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Slawomir Wojciech Wojtczak 2024-01-23 18:06:58 UTC
Created attachment 247895 [details]
lsblk.diff (BROKEN)

Hi.

Please update the 'sysutils/lsblk' port to 3.8 with attached DIFF.

Changelog
---------

- Remove '?' characters from device description.
- Allow use of disks with full /dev/ path as argument.
- Calculate width for device column.
- Fix printing glabel(1) labels with spaces.

Thank You,
vermaden
Comment 1 Slawomir Wojciech Wojtczak 2024-01-24 09:10:17 UTC
Comment on attachment 247895 [details]
lsblk.diff (BROKEN)

diff -u lsblk.orig/Makefile lsblk/Makefile
--- lsblk.orig/Makefile 2023-10-16 00:26:28.914059000 +0200
+++ lsblk/Makefile      2024-01-24 10:02:28.041191000 +0100
@@ -1,5 +1,5 @@
 PORTNAME=      lsblk
-PORTVERSION=   3.7
+PORTVERSION=   3.8
 CATEGORIES=    sysutils
 MASTER_SITES=  https://github.com/vermaden/lsblk/raw/master/release/
 
diff -u lsblk.orig/distinfo lsblk/distinfo
--- lsblk.orig/distinfo 2023-10-16 00:26:28.914363000 +0200
+++ lsblk/distinfo      2024-01-24 10:09:06.072436000 +0100
@@ -1,4 +1,4 @@
-TIMESTAMP = 1630176670
-SHA256 (lsblk-3.7.tar.gz) = c5d84b27c9664a4a005a01ec194df0eaeb628578d88d5f6ce9a95516dad4752b
-SIZE (lsblk-3.7.tar.gz) = 5228
+TIMESTAMP = 1630176671
+SHA256 (lsblk-3.8.tar.gz) = c399b53192dd6edbc8458a0266449be4f33e33db1360ac7d9570136fefc7844a
+SIZE (lsblk-3.8.tar.gz) = 5494
Comment 2 Slawomir Wojciech Wojtczak 2024-01-24 09:12:04 UTC
Comment on attachment 247895 [details]
lsblk.diff (BROKEN)

DO NOT USE THIS ONE.
Comment 3 Slawomir Wojciech Wojtczak 2024-01-24 09:12:21 UTC
Created attachment 247918 [details]
lsblk.diff
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-27 08:17:32 UTC
Look like you updated release without change version:
SHA256 (lsblk-3.8.tar.gz) = 931a8230e9fdf580692be95fa2f321d8d4190274d1ee651d6ac59a0285ea8eaf
SIZE (lsblk-3.8.tar.gz) = 5495
Comment 5 Slawomir Wojciech Wojtczak 2024-01-27 14:42:51 UTC
(In reply to Vladimir Druzenko from comment #4)

The version in the Ports is 3.7 and I would want to update it to new 3.8 version.

I first added WRONG *lsblk.diff* file - so I removed the first one - and then added PROPER *lsblk.diff* for the second time.

Hope that helps.

Regards,
vermaden
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-27 15:41:09 UTC
(In reply to Slawomir Wojciech Wojtczak from comment #5)
Check here: https://github.com/vermaden/lsblk/tree/master/release
File size is 5495, but in your patch 5494.
SHA256 is different too.

You are the developer of the lsblk (same email).
You replaced lsblk-3.8.tar.gz file at github after you create patch here.
I got error during fetch - size mismatch.
Comment 7 Slawomir Wojciech Wojtczak 2024-01-27 16:48:05 UTC
Created attachment 248010 [details]
lsblk.diff - THIS ONE WORKS
Comment 8 Slawomir Wojciech Wojtczak 2024-01-27 16:49:08 UTC
(In reply to Slawomir Wojciech Wojtczak from comment #7)

I am sorry ... I just uploaded the one that works and I believe is correct.

This one (lsblk.diff - THIS ONE WORKS):
- https://bugs.freebsd.org/bugzilla/attachment.cgi?id=248010

Sorry for pointlessly wasting Your time.

I hope now its OK.

Regards,
vermaden
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-01-27 19:27:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=43c708e0950cb2e8149ffebce1aa8317bc466958

commit 43c708e0950cb2e8149ffebce1aa8317bc466958
Author:     Slawomir Wojciech Wojtczak <vermaden@interia.pl>
AuthorDate: 2024-01-27 19:20:35 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-01-27 19:26:12 +0000

    sysutils/lsblk: update to 3.8

    Changelog
    ---------
    - Remove '?' characters from device description.
    - Allow use of disks with full /dev/ path as argument.
    - Calculate width for device column.
    - Fix printing glabel(1) labels with spaces.

    PR:             276561
    Approved by:    vermaden@interia.pl (maintainer), arrowd (mentor)

 sysutils/lsblk/Makefile | 2 +-
 sysutils/lsblk/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-27 19:28:51 UTC
Thanks.
Comment 11 Slawomir Wojciech Wojtczak 2024-01-27 20:45:23 UTC
(In reply to Vladimir Druzenko from comment #10)

Thank You.