Created attachment 247902 [details] Patch to base system (use 'patch' or 'git apply') Hi, I would like an exp-run for the attached patch against base, which is a squash of all still-open reviews in the series starting at review D40344. This is essentially because I'm removing two public macros, LOGIN_DEFUMASK and LOGIN_DEFPRI, which are in reality implementation details. I have already checked via Google and GitHub and they don't seem to be used by any external project. Thanks and regards.
Exp-run seems fine
(In reply to Antoine Brodin from comment #1) Noted. Thanks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=e3a396eb2a029e5dc9161469735aa3f7f16845d1 commit e3a396eb2a029e5dc9161469735aa3f7f16845d1 Author: Olivier Certner <olce@FreeBSD.org> AuthorDate: 2024-01-25 22:10:40 +0000 Commit: Olivier Certner <olce@FreeBSD.org> CommitDate: 2024-01-29 21:58:10 +0000 login_cap.h: Remove LOGIN_DEFUMASK This public constant has not been used in-tree since 1997 (this was noticed while working on previous commit "setusercontext(): umask: Set it only once (in the common case)"). Since it was an implementation detail and GitHub's code search and Google show no use of this symbol today, simply remove it. PR: 276570 (exp-run) Reviewed by: emaste, kib (earlier version, then part of D40344) Approved by: emaste (mentor) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43608 lib/libutil/login_cap.h | 1 - 1 file changed, 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=c7e645269f1c7e9872a7ccf6b72f045c55a66793 commit c7e645269f1c7e9872a7ccf6b72f045c55a66793 Author: Olivier Certner <olce@FreeBSD.org> AuthorDate: 2024-01-25 22:25:10 +0000 Commit: Olivier Certner <olce@FreeBSD.org> CommitDate: 2024-01-29 21:58:10 +0000 login_cap.h: Remove LOGIN_DEFPRI This is an implementation detail which is likely to become irrelevant in the future, as we move to not resetting the priority if the corresponding capability is not present in the configuration file ('/etc/login.conf'). GitHub's code search and Google show no use of this public constant, and it doesn't exist in OpenBSD and NetBSD. So, remove this definition and its sole use in-tree. PR: 276570 (exp-run) Reviewed by: emaste Approved by: emaste (mentor) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43609 lib/libutil/login_cap.h | 1 - lib/libutil/login_class.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=943af0501107f88312a98b217b6956f3d0f2fa76 commit 943af0501107f88312a98b217b6956f3d0f2fa76 Author: Olivier Certner <olce@FreeBSD.org> AuthorDate: 2024-01-25 22:10:40 +0000 Commit: Olivier Certner <olce@FreeBSD.org> CommitDate: 2024-02-01 21:24:22 +0000 login_cap.h: Remove LOGIN_DEFUMASK This public constant has not been used in-tree since 1997 (this was noticed while working on previous commit "setusercontext(): umask: Set it only once (in the common case)"). Since it was an implementation detail and GitHub's code search and Google show no use of this symbol today, simply remove it. PR: 276570 (exp-run) Reviewed by: emaste, kib (earlier version, then part of D40344) Approved by: emaste (mentor) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43608 (cherry picked from commit e3a396eb2a029e5dc9161469735aa3f7f16845d1) Approved by: markj (mentor) lib/libutil/login_cap.h | 1 - 1 file changed, 1 deletion(-)
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=634f86a3c47ffc8dfe7699ea599ab34c88b25324 commit 634f86a3c47ffc8dfe7699ea599ab34c88b25324 Author: Olivier Certner <olce@FreeBSD.org> AuthorDate: 2024-01-25 22:25:10 +0000 Commit: Olivier Certner <olce@FreeBSD.org> CommitDate: 2024-02-01 21:24:30 +0000 login_cap.h: Remove LOGIN_DEFPRI This is an implementation detail which is likely to become irrelevant in the future, as we move to not resetting the priority if the corresponding capability is not present in the configuration file ('/etc/login.conf'). GitHub's code search and Google show no use of this public constant, and it doesn't exist in OpenBSD and NetBSD. So, remove this definition and its sole use in-tree. PR: 276570 (exp-run) Reviewed by: emaste Approved by: emaste (mentor) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43609 (cherry picked from commit c7e645269f1c7e9872a7ccf6b72f045c55a66793) Approved by: markj (mentor) lib/libutil/login_cap.h | 1 - lib/libutil/login_class.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)
A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=7e2bfa3d7a2a3025c6351a35b4ea52cdb2ea9c2f commit 7e2bfa3d7a2a3025c6351a35b4ea52cdb2ea9c2f Author: Olivier Certner <olce@FreeBSD.org> AuthorDate: 2024-01-25 22:25:10 +0000 Commit: Olivier Certner <olce@FreeBSD.org> CommitDate: 2024-02-01 21:30:20 +0000 login_cap.h: Remove LOGIN_DEFPRI This is an implementation detail which is likely to become irrelevant in the future, as we move to not resetting the priority if the corresponding capability is not present in the configuration file ('/etc/login.conf'). GitHub's code search and Google show no use of this public constant, and it doesn't exist in OpenBSD and NetBSD. So, remove this definition and its sole use in-tree. PR: 276570 (exp-run) Reviewed by: emaste Approved by: emaste (mentor) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43609 (cherry picked from commit c7e645269f1c7e9872a7ccf6b72f045c55a66793) Approved by: markj (mentor) lib/libutil/login_cap.h | 1 - lib/libutil/login_class.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)
A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=ce92a977dbd24301f5f5348d45f51795c5f98786 commit ce92a977dbd24301f5f5348d45f51795c5f98786 Author: Olivier Certner <olce@FreeBSD.org> AuthorDate: 2024-01-25 22:10:40 +0000 Commit: Olivier Certner <olce@FreeBSD.org> CommitDate: 2024-02-01 21:30:14 +0000 login_cap.h: Remove LOGIN_DEFUMASK This public constant has not been used in-tree since 1997 (this was noticed while working on previous commit "setusercontext(): umask: Set it only once (in the common case)"). Since it was an implementation detail and GitHub's code search and Google show no use of this symbol today, simply remove it. PR: 276570 (exp-run) Reviewed by: emaste, kib (earlier version, then part of D40344) Approved by: emaste (mentor) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43608 (cherry picked from commit e3a396eb2a029e5dc9161469735aa3f7f16845d1) Approved by: markj (mentor) lib/libutil/login_cap.h | 1 - 1 file changed, 1 deletion(-)