Bug 276620 - MAINTAINER reclamation (meta-port diff)
Summary: MAINTAINER reclamation (meta-port diff)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-25 22:40 UTC by Chris Hutchinson
Modified: 2024-01-26 08:48 UTC (History)
2 users (show)

See Also:


Attachments
git diff for MAINTAINER reclamation (8.95 KB, patch)
2024-01-25 22:40 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
git diff for MAINTAINER reclamation ( without PROTREVISION bump ) (8.09 KB, patch)
2024-01-26 00:57 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2024-01-25 22:40:31 UTC
Created attachment 247962 [details]
git diff for MAINTAINER reclamation

The attached git diff (patch) returns MAINTAINER to me
after a sweeping commit (mistakenly) removed me.

CHANGES
 * MAINTAINER
 * DEPRECIATED (in a few cases)

As to the removal of DEPRECIATED in a few cases:
These ports continue to work as intended. In spite of their
projects (in)activity. :)

Thanks!

--Chris
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-01-25 23:16:50 UTC
This has been explained to you before,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276387#c7
Comment 2 Chris Hutchinson 2024-01-25 23:20:05 UTC
(In reply to Daniel Engberg from comment #1)
Right. I'm not ignoring that.
Comment 3 Chris Hutchinson 2024-01-25 23:25:29 UTC
(In reply to Chris Hutchinson from comment #2)
To be more concise; I did *not* add myself nor remove depreciated
from all the ports affected by your sweeping commit. Just those
that still appeared active, and still worked effectively and as intended. :)
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2024-01-26 00:06:45 UTC
I think that this kind of update doesn't require PORTREVISION bump.
Comment 5 Chris Hutchinson 2024-01-26 00:43:17 UTC
(In reply to Koichiro Iwao from comment #4)
Sorry. I think you're right. I'm not always sure when
to do it. I'll submit a new patch w/o PORTREVISION changes
shortly.

Thanks!

--Chris
Comment 6 Chris Hutchinson 2024-01-26 00:57:26 UTC
Created attachment 247968 [details]
git diff for MAINTAINER reclamation ( without PROTREVISION bump )

This time w/o PORTREVISION changes.

Thanks, and sorry.

--Chris
Comment 7 Koichiro Iwao freebsd_committer freebsd_triage 2024-01-26 02:14:03 UTC
IMO, it is fine to keep ports in the tree if the port has a maintainer still willing to maintain them and they're working effectively.
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-01-26 02:16:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4240a87e2fdebe7c8005967abbe446fd0942071c

commit 4240a87e2fdebe7c8005967abbe446fd0942071c
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2024-01-26 00:15:58 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2024-01-26 02:15:04 +0000

    */*: reassign ports to maintainer

    that were returned to pool due to BSDforge.com unavailability (5 days).
    Also, remove DEPRECATED from some ports as they have a maintainer and
    he is still willing to maintain.

    PR:             276620

 archivers/bzip/Makefile     | 2 +-
 benchmarks/ttcp/Makefile    | 5 +----
 comms/comserv/Makefile      | 5 +----
 deskutils/bigyear/Makefile  | 5 +----
 devel/codeville/Makefile    | 6 +-----
 dns/dlint/Makefile          | 2 +-
 dns/dns_balance/Makefile    | 5 +----
 dns/dnscheckengine/Makefile | 5 +----
 graphics/urt/Makefile       | 5 +----
 irc/ezbounce/Makefile       | 5 +----
 irc/ircproxy/Makefile       | 5 +----
 net/widentd/Makefile        | 5 +----
 net/xrdesktop2/Makefile     | 2 --
 13 files changed, 12 insertions(+), 45 deletions(-)
Comment 9 Koichiro Iwao freebsd_committer freebsd_triage 2024-01-26 02:56:47 UTC
Committed, thanks for your effort in maintaining many ports!
Comment 10 Chris Hutchinson 2024-01-26 05:53:41 UTC
(In reply to Koichiro Iwao from comment #9)
Thanks!
Comment 11 Koichiro Iwao freebsd_committer freebsd_triage 2024-01-26 08:41:31 UTC
I reverted un-deprecate part of your patch as per request of other committer but I keep MAINTAINER reassignment. MAINTAINER was reset to ports@ due to accidental domain unavailability but I think the former maintainer is eligible to re-grab maintainership after domain resurrection.
Comment 12 Chris Hutchinson 2024-01-26 08:48:06 UTC
(In reply to Koichiro Iwao from comment #11)
I greatly appreciate you're efforts and perspective here, Koichiro.
Thanks!

--Chris