Bug 276650 - comms/fldigi: Fix plist and modernize Makefile
Summary: comms/fldigi: Fix plist and modernize Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-26 22:46 UTC by Daniel Engberg
Modified: 2024-01-28 22:03 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (hamradio)


Attachments
Patch for fldigi (2.77 KB, patch)
2024-01-26 22:46 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-01-26 22:46:34 UTC
Created attachment 247993 [details]
Patch for fldigi

* Define LICENSE_FILE
* Remove dependency of (lib)Boost, the source code doesn't reference it at all
* Rearrange Makefile to closer follow Porters Handbook
* Drop native optimization option, rely on framework CPUTYPE variable instead
* Use framework _DESC
* Fix plist with NLS

Poudriere testport OK 14.0-RELEASE (amd64)
Poudriere testport OK 13.2-RELEASE (amd64)
Comment 1 Diane Bruce freebsd_committer freebsd_triage 2024-01-27 14:30:49 UTC
As you have a ports bit why don't you just commit this?

Approved
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-01-27 14:49:51 UTC
Because I'm not a member of hamradio and and blanket approval doesn't cover all changes.
Comment 3 Diane Bruce freebsd_committer freebsd_triage 2024-01-28 20:37:21 UTC
Approved: by db (Hamradio group)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-01-28 21:54:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3e253bc04e48ca7da20771454b670b19d2f72bf8

commit 3e253bc04e48ca7da20771454b670b19d2f72bf8
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-01-27 14:53:39 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-01-28 21:53:04 +0000

    comms/fldigi: Fix plist and modernize Makefile

    * Define LICENSE_FILE
    * Remove dependency of (lib)Boost, the source code doesn't reference it at all
    * Rearrange Makefile to closer follow Porters Handbook
    * Drop native optimization option, rely on framework CPUTYPE variable instead
    * Use framework _DESC
    * Fix plist with NLS

    PR:             276650
    Approved by:    hamradio (db)

 comms/fldigi/Makefile  | 38 +++++++++++++++-----------------------
 comms/fldigi/pkg-plist |  1 +
 2 files changed, 16 insertions(+), 23 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-01-28 22:03:51 UTC
Thanks! =)