Bug 276724 - 'man 8 glabel': add extra content
Summary: 'man 8 glabel': add extra content
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-29 22:21 UTC by Alex Matei
Modified: 2024-11-25 05:08 UTC (History)
2 users (show)

See Also:


Attachments
patch for glabel man page (756 bytes, patch)
2024-02-17 18:16 UTC, Chris Moerz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Matei 2024-01-29 22:21:37 UTC
This bug is derived from the bug 276547.
I would add the update made by the developer MJ to the glabel man page ('man 8 glabel')
under the following paragraph:

   label     Set up a label name for the given provider. ...
...

It would be useful for the FreeBSD community.
Thanks.
Comment 1 Chris Moerz 2024-02-17 18:16:29 UTC
Created attachment 248538 [details]
patch for glabel man page

Adding a patch - suggesting to add a paragraph that outlines the requirement to either not have a device's file system mounted or in read-only mode to be able to persist changes.
Comment 2 Chris Moerz 2024-03-16 20:04:59 UTC
Added a Phabricator review to simplify the patch creation and review:
https://reviews.freebsd.org/D44394
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-21 18:51:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c80c104cbd52db994c0f2757bd1c6d014744022c

commit c80c104cbd52db994c0f2757bd1c6d014744022c
Author:     Chris Moerz <freebsd@ny-central.org>
AuthorDate: 2024-05-21 18:10:11 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2024-05-21 18:49:17 +0000

    glabel.8: Describe cases related to permissions / existing mounts

    Specially, note some requirements for label changes:

    - glabel requires write permission on device
    - filesystems first need to be unmounted for new labels to persist
      across reboots
    - if the affected device node holds the filesystem root, single-user
      mode with r/o mount will be required.

    Also, while here, apply some formatting tweaks.

    PR:             276724
    Reported by:    Alex Matei <matei35@yahoo.com>
    Reviewed by:    gbe, jrm, Alexander Ziaee <concussious@runbox.com>
    Differential Revision:  https://reviews.freebsd.org/D44394

 lib/geom/label/glabel.8 | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)
Comment 4 Chris Moerz 2024-06-09 14:00:08 UTC
If anyone sees this - we can close this, since we committed an update.
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2024-06-09 16:28:50 UTC
^Triage: committed.