Bug 276759 - benchmarks/ttcp: MANPAGEPREFIX, pet pkg-fallout@, upgrade to current version
Summary: benchmarks/ttcp: MANPAGEPREFIX, pet pkg-fallout@, upgrade to current version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2024-02-01 04:18 UTC by Chris Hutchinson
Modified: 2024-02-24 08:48 UTC (History)
3 users (show)

See Also:
portmaster: maintainer-feedback+


Attachments
patch to fix manprefix on benchmarks/ttcp (808 bytes, patch)
2024-02-01 04:18 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
patch fix MANPAGEPREFIX, upgrade with new source location (9.79 KB, patch)
2024-02-01 22:44 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
update to last patch. (version2) (9.81 KB, patch)
2024-02-02 06:15 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
updated patch (version 3) for benchmarks/ttcp (9.82 KB, patch)
2024-02-02 09:11 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
patch (version 4) for benchmarks/ttcp (9.83 KB, patch)
2024-02-20 06:35 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2024-02-01 04:18:22 UTC
Created attachment 248112 [details]
patch to fix manprefix on benchmarks/ttcp

The patch attached to this pr(1) essentially
simply fixes MANPAGEPREFIX, but to streamline the
process, move pkg-plist to Makefile, removed pkg-plist
and bump PORTREVISION to signal pkg-fallout@ a
"new and improved version is available to build".

Thanks, that's it!

--Chris
Comment 1 Chris Hutchinson 2024-02-01 22:44:35 UTC
Created attachment 248122 [details]
patch fix MANPAGEPREFIX, upgrade with new source location

Updated patch; source has moved, and has a new version.
This patch covers:

MANPAGEPREFIX fix
upgrade to new version
new MASTER_SITES
new WWW
removes (now) unnecessary patchfiles
pkg-plist is short; move to Makefile

tested on releng/14 && 15-current.

That's it. Thanks.

--Chris
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-02-02 02:25:56 UTC
Patch is incorrect

Use https://codeberg.org/${ACCOUNTNAME}/${PROJECTNAME}/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/

Why the license change?

What's the reason to keep this in (which have been already dropped by most major distros already)?
Comment 3 Chris Hutchinson 2024-02-02 03:01:39 UTC
(In reply to Daniel Engberg from comment #2)
LICENSE; so that the original author(s) are remembered for their
work.
I can't speak for "other" distros. Not sure how that would
even apply. It works well && as intended. Now that it's on
a public VCS, it'll be possible to include/add improvements
or features. :)

Thanks for taking the time to look into this.

--Chris
Comment 4 Chris Hutchinson 2024-02-02 06:15:23 UTC
Created attachment 248129 [details]
update to last patch.  (version2)

brings it more in line with other codeberg URL's in the
ports tree. Influenced by a recommendation from diizzy@.

That's it, and thanks.
Comment 5 Chris Hutchinson 2024-02-02 06:33:18 UTC
(In reply to Daniel Engberg from comment #2)
I just tallied up the unique installs for this month;
grep ttcp.c /path/to/bsdwatch/access/log | grep libfetch | grep -Eiv freebsd |
awk '{print $1}' | uniq | wc -l
131
So 131 unique installs for the month of January, not counting freebsd as
a host/ip. So it seems still popular enough to keep it around. May well
become even more popular now that it's in a public VCS?
Comment 6 Chris Hutchinson 2024-02-02 09:11:17 UTC
Created attachment 248132 [details]
updated patch (version 3) for benchmarks/ttcp

Since this hasn't been committed yet. I took the liberty of
adding a couple of small changes I forgot. Nothing worth
mentioning. But required a makesum (distinfo).

Thanks!

--Chris
Comment 7 Chris Hutchinson 2024-02-20 06:35:54 UTC
Created attachment 248624 [details]
patch (version 4) for benchmarks/ttcp

Updates previous patch (version 4).
Can we please get this committed? pkg-fallout has failing and
complaining needlessly for quite some time now.
This is an easy commit.

tested on 14/releng && current.

--Chris
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-02-24 08:48:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b10b5eaba2f20b96afa5ff129d759a9e62d7fb52

commit b10b5eaba2f20b96afa5ff129d759a9e62d7fb52
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2024-02-24 08:46:06 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-02-24 08:46:31 +0000

    benchmarks/ttcp: Simplify Makefile

    PR:             276759

 benchmarks/ttcp/Makefile | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-02-24 08:48:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=36c21f98ff445e373ab61726ee8b64e02f8984f7

commit 36c21f98ff445e373ab61726ee8b64e02f8984f7
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2024-02-24 08:43:41 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-02-24 08:46:30 +0000

    benchmarks/ttcp: Update to 1.13

    PR:             276759

 benchmarks/ttcp/Makefile                  |  29 ++--
 benchmarks/ttcp/distinfo                  |   9 +-
 benchmarks/ttcp/files/patch-ttcp.c (gone) | 257 ------------------------------
 benchmarks/ttcp/pkg-plist (gone)          |   3 -
 4 files changed, 15 insertions(+), 283 deletions(-)
Comment 10 Gleb Popov freebsd_committer freebsd_triage 2024-02-24 08:48:58 UTC
Pushed in, thanks!