Bug 276851 - website: fix MFC glossary links
Summary: website: fix MFC glossary links
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Website (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-doc (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-06 07:58 UTC by Paul Ivanov
Modified: 2024-02-07 03:46 UTC (History)
1 user (show)

See Also:

Attachments
patch to fix MFC glossary links on the website (26.40 KB, patch)
2024-02-06 07:58 UTC, Paul Ivanov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Ivanov 2024-02-06 07:58:22 UTC 
Created attachment 248215 [details]
patch to fix MFC glossary links on the website

For example, if you go to https://www.freebsd.org/releases/13.3R/schedule/ the link for MFC in "MFC requests should be sent to..." will (incorrectly) direct you to https://docs.freebsd.org/en/books/handbook/#mfc-glossary whereas with this patch it will take you to https://docs.freebsd.org/en/books/handbook/glossary/#mfc-glossary

I generated this with 

cd website;
git grep -l mfc-gloss | xargs sed -i -e "s/}#mfc-glossary/}glossary\/#mfc-glossary/"

An alternative to this patch would be to use the single-page handbook URL everywhere
https://docs.freebsd.org/en/books/handbook/book/#mfc-glossary
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-02-07 03:45:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=bc660d4f75a7fbcf5be783e6bd48d0eed94cb234

commit bc660d4f75a7fbcf5be783e6bd48d0eed94cb234
Author:     Paul Ivanov <pi@berkeley.edu>
AuthorDate: 2024-02-07 03:44:23 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-02-07 03:44:23 +0000

    website: fix MFC glossary links

    MFC links are incorrectly redirected to the main handbook, not the
    glossary subdirectory. Mechanically rewrite to redirect to the right
    place. Change all the redirections from
    https://docs.freebsd.org/en/books/handbook/#mfc-glossary
    to
    https://docs.freebsd.org/en/books/handbook/glossary/#mfc-glossary

    PR: 276851
    Reviewed by: imp

 website/archetypes/release/schedule.adoc        | 4 ++--
 website/content/en/releases/10.0R/schedule.adoc | 2 +-
 website/content/en/releases/10.1R/schedule.adoc | 2 +-
 website/content/en/releases/10.2R/schedule.adoc | 2 +-
 website/content/en/releases/10.3R/schedule.adoc | 2 +-
 website/content/en/releases/10.4R/schedule.adoc | 2 +-
 website/content/en/releases/11.0R/schedule.adoc | 2 +-
 website/content/en/releases/11.1R/schedule.adoc | 2 +-
 website/content/en/releases/11.2R/schedule.adoc | 2 +-
 website/content/en/releases/11.3R/schedule.adoc | 2 +-
 website/content/en/releases/11.4R/schedule.adoc | 2 +-
 website/content/en/releases/12.0R/schedule.adoc | 2 +-
 website/content/en/releases/12.1R/schedule.adoc | 2 +-
 website/content/en/releases/12.2R/schedule.adoc | 4 ++--
 website/content/en/releases/12.3R/schedule.adoc | 4 ++--
 website/content/en/releases/12.4R/schedule.adoc | 4 ++--
 website/content/en/releases/13.0R/schedule.adoc | 4 ++--
 website/content/en/releases/13.1R/schedule.adoc | 2 +-
 website/content/en/releases/13.2R/schedule.adoc | 2 +-
 website/content/en/releases/13.3R/schedule.adoc | 2 +-
 website/content/en/releases/14.0R/schedule.adoc | 4 ++--
 website/content/en/releases/9.1R/schedule.adoc  | 2 +-
 website/content/en/releases/9.2R/schedule.adoc  | 2 +-
 website/content/en/releases/9.3R/schedule.adoc  | 2 +-
 website/content/en/releng/_index.adoc           | 2 +-
 25 files changed, 31 insertions(+), 31 deletions(-)
Comment 2 Warner Losh freebsd_committer freebsd_triage 2024-02-07 03:46:21 UTC 
looks good. Seems to work locally, but I'll double check the website once it rebuilds.

Thanks!