Created attachment 248341 [details] New Port patch RedNotebook is a personal desktop journal application written in Python. This used to be in ports, but was removed due to relying on an old webkit-gtk2 port back in 2019. The application has been updated and I created this new port. See attached patch. I use this application, and am happy to be able to contribute this back to the community and maintain it. Thanks! Travis
Hmm. Running make, make stage, make stage-qa, make package, and portlint in my ports tree all worked with no issues. Poudriere failed. I'm working that out now. I'll submit a new patch when it also builds in poudriere (on amd64 at least) -Travis
New patch uploaded. Builds in poudriere. If you'd like to see any output or logs, let me know and I can attach those.
Created attachment 248361 [details] Updated patch Updated new port patch. Should pass poudriere testport now, in addition to portlint
Bump. Any issues with this port/patch? The patch applies cleanly to my tree, and builds without any warnings from poudriere and portlint. Let me know if there is something else I need to do to get this merged in. Thanks! Travis
Created attachment 248920 [details] Poudriere testport log Poudriere testport log
Gnome stuff should be depended on via USES=gnome and USE_GNOME=things. See https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-gnome
Created attachment 248924 [details] New patch to USE_GNOME Thanks! I updated the port to USE_GNOME. I still need gettext build dependency (intltool and intlhack didn't suffice), and there aren't any USE variables that supply the webkit2-gtk3 dependency I could find, so those are still explicit.
Created attachment 248925 [details] Poudriere testport log New testport log for USE_GNOME change.
Created attachment 248926 [details] testport log Wrong log. Updating testport log instead of bulk log.
A correct dependency line for webkit is LIB_DEPENDS= libwebkit2gtk-4.0.so:www/webkit2-gtk3 The gettext-runtime dependency is also handled by a corresponding USES. Also, install portlint tool and run it over your port to make sure there are no inconsistencies.
Hi Travis, Nice port! I saw your request for feedback. I looked it over and while I have little to offer in terms of experience with ports, I did catch one possible nit. It appears there may be some odd space/tab formatting in the Makefile. I noticed this in the diff where certain parameters that I would expect to be level were not. Just figured I would mention it since you requested feedback. To me, though, it looks good! Nice work! Definitely not the simplest port one could do.
(In reply to Gleb Popov from comment #10) Gleb, I've attached a new patch. As for portlint, I've been running it all along and up until this latest patch with the switch to USES from BUILD_DEPENDS for gettext, it reported "Looks fine." Here is the output of portlint -A deskutils/rednotebook: WARN: /usr/ports/deskutils/rednotebook/pkg-plist: [133]: this port installs .desktop files. If the .desktop file(s) installed contain ``MimeType='', you must add `desktop-file-utils` to USES. WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support. 0 fatal errors and 2 warnings found. As for the first: the port does install a .desktop file but it does *not* have MimeType parameter, so this warning can be ignored? As for the second: I have not able to remove this warning (This warning does not occur when using BUILD_DEPENDS= gettext however). Upstream states gettext is a requirement for installation, and the setup.py file runs gettext when installing the application. I haven't been able to add any NLS knobs to disable it as suggested by the Porters Handbook. Thoughts? Leave it alone, or go back to using BUILD_DEPENDS?
Created attachment 248941 [details] RedNotebook Port patch New patch with PR changes
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=53e52818831c9f84f857c1ff70e46ccb6e15abf0 commit 53e52818831c9f84f857c1ff70e46ccb6e15abf0 Author: Travis Hunter <cth-freebsd@pm.me> AuthorDate: 2024-03-07 17:00:22 +0000 Commit: Kurt Jaeger <pi@FreeBSD.org> CommitDate: 2024-03-07 17:00:22 +0000 deskutils/rednotebook: new port RedNotebook is a modern desktop journal. It lets you format, tag, and search your entries. You can also add pictures, links, and customizable templates, spell check your notes, and export to plain text, HTML, LaTeX, or PDF. PR: 276963 Author: Travis Hunter <cth-freebsd@pm.me> Reviewed-by: arrowd, henrichhartzer@tuta.io deskutils/Makefile | 1 + deskutils/rednotebook/Makefile (new) | 30 +++++ deskutils/rednotebook/distinfo (new) | 3 + deskutils/rednotebook/pkg-descr (new) | 3 + deskutils/rednotebook/pkg-plist (new) | 201 ++++++++++++++++++++++++++++++++++ 5 files changed, 238 insertions(+)
Committed, thanks!