Bug 277022 - x11/lightdm 1.32.0_2 fails in package phase
Summary: x11/lightdm 1.32.0_2 fails in package phase
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-13 12:23 UTC by Marko Cupać
Modified: 2024-02-26 13:28 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Cupać 2024-02-13 12:23:32 UTC
Hi,

I can't build lightdm-1.32.0_2 for 14.0 amd64 in poudriere.

Perhaps having disabled DOCS could matter.

Here's log excerpt:

---Begin OPTIONS List---
===> The following configuration options are available for lightdm-1.32.0_2:
     DOCS=off: Build and/or install documentation
     QT5=off: Qt 5 toolkit support
     VAPI=on: Build VALA API files
===> Use 'make config' to modify these settings
---End OPTIONS List---
(...)
===========================================================================
=======================<phase: package        >============================
===== env: 'PKG_NOTES=build_timestamp ports_top_git_hash ports_top_checkout_unclean port_git_hash port_checkout_unclean built_by' 'PKG_NOTE_build_timestamp=2024-02-13T12:10:43+0000' 'PKG_NOTE_ports_top_git_hash=102aeecc964' 'PKG_NOTE_ports_top_checkout_unclean=no' 'PKG_NOTE_port_git_hash=23a47f28de2' 'PKG_NOTE_port_checkout_unclean=no' 'PKG_NOTE_built_by=poudriere-git-3.4.1' NO_DEPENDS=yes USER=nobody UID=65534 GID=65534
===>  Building packages for lightdm-1.32.0_2
===>   Building lightdm-1.32.0_2
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/autologin.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/config.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/default-greeter.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/default-session.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/diagnostics.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/guest.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/index.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/legal.xml:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/local-sessions.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/remote-sessions.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/seat.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/standard-authentication.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/user-list.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/user-switching.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/vnc.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/write-greeter.page:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/lightdm/work/stage/usr/local/share/help/C/lightdm/xdmcp.page:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/x11/lightdm
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2024-02-13 13:52:49 UTC
Hi!

Thanks for reporting.

Yes it looks like an issue with the docs flag.

I'm going to give it a look shortly and try to fix it.

Will report back as soon as I have something.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2024-02-13 14:03:09 UTC
Interesting enough, a first try at reproducing this failed here.

I need to investigate further. Could take a little longer than I expected.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2024-02-13 14:05:48 UTC
I correct myself, I did reproduce it:

This happens only if VAPI is ON while DOCS is OFF.

When I updated the port last time I did not test this combination. I usually test "all options ON", "all options OFF" and "default options". Testing all possible options permutations gets prohibitive fast, so this kind of corner cases is unavoidable.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-02-13 20:27:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9b0bf17a5c4eebafdfe5b4e5463002e169857295

commit 9b0bf17a5c4eebafdfe5b4e5463002e169857295
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-02-13 20:25:14 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-02-13 20:25:14 +0000

    x11/lightdm: Fix packaging with non default options

    When VAPI is on and DOCS is off the port fails to package. Correct
    in plist. [1]

    While here also implement an NLS option.

    PR:             277022 [1]
    MFH:            2024Q1

 x11/lightdm/Makefile  |   9 ++-
 x11/lightdm/pkg-plist | 212 +++++++++++++++++++++++++-------------------------
 2 files changed, 112 insertions(+), 109 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-02-13 20:28:12 UTC
A commit in branch 2024Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=584f5a51e9a8081e565263950dde6b26907cb7b7

commit 584f5a51e9a8081e565263950dde6b26907cb7b7
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-02-13 20:25:14 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-02-13 20:27:14 +0000

    x11/lightdm: Fix packaging with non default options

    When VAPI is on and DOCS is off the port fails to package. Correct
    in plist. [1]

    While here also implement an NLS option.

    PR:             277022 [1]
    MFH:            2024Q1
    (cherry picked from commit 9b0bf17a5c4eebafdfe5b4e5463002e169857295)

 x11/lightdm/Makefile  |   9 ++-
 x11/lightdm/pkg-plist | 212 +++++++++++++++++++++++++-------------------------
 2 files changed, 112 insertions(+), 109 deletions(-)
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2024-02-13 20:29:15 UTC
Committed a fix, please report back that it works correctly.

Thanks!
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2024-02-18 16:43:32 UTC
Patch committed, looks fine here and on cluster (no pkg-fallout notifications)
Comment 8 Marko Cupać 2024-02-26 13:28:23 UTC
(In reply to Guido Falsi from comment #6)

Hi Guido,

port now builds, installs and works fine. Thanks!

I opened another issue about overwriting pam.d/lightdm file:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277330

Best regards,