Bug 277098 - archivers/zlib-ng: fix build tests
Summary: archivers/zlib-ng: fix build tests
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Loïc Bartoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-16 21:42 UTC by Max Brazhnikov
Modified: 2024-02-22 17:28 UTC (History)
0 users

See Also:
lbartoletti: maintainer-feedback+

Attachments
patch (1.04 KB, patch)
2024-02-16 21:42 UTC, Max Brazhnikov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Brazhnikov freebsd_committer freebsd_triage 2024-02-16 21:42:33 UTC 
Created attachment 248515 [details]
patch

I've always avoided dealing with testing in ports before, now I understand why :)
I think testing framework should be implemented as a feature (like WITH_DEBUG) and not via options. Anyway, this patch fixes build with tests, all tests passed successfully.
Comment 1 Loïc Bartoletti freebsd_committer freebsd_triage 2024-02-21 12:29:13 UTC 
Thanks, push it!
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-02-22 17:22:43 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e86f4ac9642148525a2b4356dc211526226acdd5

commit e86f4ac9642148525a2b4356dc211526226acdd5
Author:     Max Brazhnikov <makc@FreeBSD.org>
AuthorDate: 2024-02-22 17:21:37 +0000
Commit:     Max Brazhnikov <makc@FreeBSD.org>
CommitDate: 2024-02-22 17:21:37 +0000

    archivers/zlib-ng: fix build with TEST option

    PR:             277098
    Approved by:    maintainer

 archivers/zlib-ng/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)