Bug 277102 - sysutils/py-scandir: Apply upstream patch to fix build with python-3.11
Summary: sysutils/py-scandir: Apply upstream patch to fix build with python-3.11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks: 275494
  Show dependency tree / graph
 
Reported: 2024-02-16 23:34 UTC by Wen Heping
Modified: 2024-03-23 15:05 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Fix build with python-3.11 (3.57 KB, text/plain)
2024-02-16 23:34 UTC, Wen Heping 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wen Heping freebsd_committer freebsd_triage 2024-02-16 23:34:52 UTC 
Created attachment 248516 [details]
Fix build with python-3.11

Fix build with python-3.11
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-03-09 14:09:36 UTC 
Doesn't the upstream fix [1] fix the build on Python 3.11?

[1] https://github.com/benhoyt/scandir/commit/7ee0915f68d05dd187bea94ca1869bbeb1ea1d70
Comment 2 wen 2024-03-10 01:36:09 UTC 
(In reply to Po-Chuan Hsieh from comment #1)
Yes, upstream fix it, but upstream did not update the version, so I copied the upstream patch here, just as the PR subject say.
Comment 3 wen 2024-03-10 01:36:55 UTC 
(In reply to wen from comment #2)
But there is a typo in subject :(
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-03-11 08:19:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c37f4c4df1baaa3c57dbf461bfe97fa1b3644f86

commit c37f4c4df1baaa3c57dbf461bfe97fa1b3644f86
Author:     Wen Heping <wen@FreeBSD.org>
AuthorDate: 2024-03-11 08:15:10 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2024-03-11 08:17:33 +0000

    sysutils/py-scandir: Apply upstream patch to fix build with python-3.11

    PR:             277102
    Reported by:    wen@
    Approved by:    maintainer(timeout, > 20 days)

 sysutils/py-scandir/Makefile               |  2 +-
 sysutils/py-scandir/files/patch-_scandir.c | 68 +++++++++++++++++++++++++++---
 2 files changed, 62 insertions(+), 8 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-03-23 15:05:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9851b2321f2d9d8272679f8dcd81286477826ecf

commit 9851b2321f2d9d8272679f8dcd81286477826ecf
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-03-23 14:22:38 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-03-23 14:49:32 +0000

    sysutils/py-scandir: Fix c37f4c4df1baaa3c57dbf461bfe97fa1b3644f86

    - Add comment

    Document that it is a cumulative patch which includes 3 commits, not just the one for Python 3.11 fix.

    PR:             277102
    Obtained from:  https://github.com/benhoyt/scandir/commit/4b5354de65413b9c5c6672f5f30c532bfda4d40a
                    https://github.com/benhoyt/scandir/commit/3396aa4155ffde8600a0e9ca50d5872569169b5d
                    https://github.com/benhoyt/scandir/commit/7ee0915f68d05dd187bea94ca1869bbeb1ea1d70

 sysutils/py-scandir/files/patch-_scandir.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)