Bug 277123 - irc/znc-clientbuffer: Add PORTSCOUT
Summary: irc/znc-clientbuffer: Add PORTSCOUT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-17 22:36 UTC by Manuel Wiesinger
Modified: 2024-09-08 18:16 UTC (History)
2 users (show)

See Also:
uzsolt: maintainer-feedback?

Attachments
0001-irc-znc-clientbuffer-Add-PORTSCOUT.patch (625 bytes, patch)
2024-02-17 22:36 UTC, Manuel Wiesinger 		no flags Details | Diff
0001-irc-znc-clientbuffer-Add-PORTSCOUT.patch (626 bytes, patch)
2024-09-07 10:55 UTC, Manuel Wiesinger 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Wiesinger freebsd_committer freebsd_triage 2024-02-17 22:36:11 UTC 
Created attachment 248552 [details]
0001-irc-znc-clientbuffer-Add-PORTSCOUT.patch

Upstream version znc-1.6.0 is older than v1.0.48

portlint -AC passed
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2024-02-17 22:36:11 UTC 
Maintainer informed via mail
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-15 18:50:13 UTC 
(In reply to Manuel Wiesinger from comment #0)
Why do you want use portscout? As I see the latest version of znc-clientbuffer is 1.0.48. I think the znc's version doesn't disturb it.
Comment 3 Manuel Wiesinger freebsd_committer freebsd_triage 2024-09-05 13:40:24 UTC 
znc-clientbuffer changed its version scheme, so for portscout znc-clientbuffer version "znc-1.6.0" appears newer than "v1.0.48", which is the latest. See https://github.com/CyberShadow/znc-clientbuffer/tags
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-05 18:01:31 UTC 
(In reply to Manuel Wiesinger from comment #3)
Indeed.
What do you think about skipv (https://github.com/freebsd/portscout/blob/master/docs/portscout-portconfig.txt)? IMHO it would be clearer.
Comment 5 Manuel Wiesinger freebsd_committer freebsd_triage 2024-09-07 10:55:13 UTC 
Created attachment 253398 [details]
0001-irc-znc-clientbuffer-Add-PORTSCOUT.patch
Comment 6 Manuel Wiesinger freebsd_committer freebsd_triage 2024-09-07 10:57:16 UTC 
(In reply to Zsolt Udvari from comment #4)
I agree, skipv is clearer, thanks for pointing it out. I updated the patch.
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-07 17:42:30 UTC 
(In reply to Manuel Wiesinger from comment #6)
You're welcome. Could you please update your email in bugzilla? It would be easier to guess that you are mdw@.
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-09-07 17:43:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f2c704807de00f8dbdf8995a1ed1496104f6d6a4

commit f2c704807de00f8dbdf8995a1ed1496104f6d6a4
Author:     Manuel Wiesinger <mdw@freebsd.org>
AuthorDate: 2024-09-07 17:39:59 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-09-07 17:40:55 +0000

    irc/znc-clientbuffer: Add PORTSCOUT

    PR:             277123
    Approved by:    submitter is maintainer

 irc/znc-clientbuffer/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 9 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-07 17:45:02 UTC 
Committed, thanks!
Comment 10 Manuel Wiesinger freebsd_committer freebsd_triage 2024-09-08 18:16:42 UTC 
(In reply to Zsolt Udvari from comment #7)
I agree, one email address would be much clearer. In my case that's not so easy. Unfortunately, I actually tried chaining it: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281371