Bug 277312 - cad/librepcb: patch needed to support opencascade-7.8.0
Summary: cad/librepcb: patch needed to support opencascade-7.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thierry Thomas
URL: https://github.com/LibrePCB/LibrePCB/...
Keywords:
Depends on:
Blocks: 277294
  Show dependency tree / graph
 
Reported: 2024-02-25 17:19 UTC by Thierry Thomas
Modified: 2024-03-21 18:08 UTC (History)
0 users

See Also:
yuri: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2024-02-25 17:19:51 UTC 
If built against opencascade-7.8.0, librepcb-1.0.0 fails with the following error:

ld: error: unable to find library -lTKXDESTEP
c++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
*** Error code 1
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2024-02-25 18:04:30 UTC 
Approved.

Please commit it.
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2024-02-26 21:47:19 UTC 
Issue reported: <https://github.com/LibrePCB/LibrePCB/issues/1315>.
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2024-03-10 17:48:45 UTC 
A patch has been submitted upstream: see <https://github.com/LibrePCB/LibrePCB/pull/1329>.
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2024-03-12 17:32:05 UTC 
See <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277312>: LibrePCB is now patched and builds fine with OpenCascade 7.8.0, but it crashes when opening a STEP file.

This bug is in OpenCascade, it has been reported, and we are waiting for a fix.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-03-21 18:03:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b7bc96ccb10409807aa1c39cf7dd3a7436476db0

commit b7bc96ccb10409807aa1c39cf7dd3a7436476db0
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2024-03-17 16:36:42 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2024-03-21 18:01:18 +0000

    cad/librepcb: add support of OpenCascade

    Patch from upstream, slightly modified because cad/opencascade has been
    fixed against the reported crash.

    PR:             277312
    Approved by:    yuri (maintainer)

 cad/librepcb/Makefile                              |  1 +
 .../files/patch-cmake_FindOpenCascade.cmake (new)  | 39 ++++++++++++++++++++++
 2 files changed, 40 insertions(+)
Comment 6 Thierry Thomas freebsd_committer freebsd_triage 2024-03-21 18:08:10 UTC 
Committed, thanks!