Comment 1 Zsolt Udvari 2024-04-09 14:38:01 UTC

The 2.0.0 is released more than three years ago (https://github.com/aureliojargas/sedsed/tags). Would you like update?

Created attachment 249861 [details]
git diff for devel/sedsed change MASTERSITES, WWW and update to version 1.1

git diff for devel/sedsed

> The 2.0.0 is released more than three years ago
> (https://github.com/aureliojargas/sedsed/tags).
> Would you like update?
This is dogfood (I use it). I use BSD sed for my workflows. Version 2 converts
this to GNU sed. Previous versions support both. Un(til|less) I can provide a
"compatibility" option/patch. I think version 2 may prove to be a bit of a POLA
for it's current user base.
So let's compromise for now, and upgrade to version 1.1; which is the newest
version before the GNU only version (2).

The attached patch accomplishes this. :)

Thanks for taking the time to work on this! :)

--Chris

Comment 3 Zsolt Udvari 2024-04-13 17:42:51 UTC

(In reply to Chris Hutchinson from comment #2)
Okay, understand. In this case could you please add a PORTSCOUT exclude (https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-portscout)? And a comment why is it not recommended to update.

Created attachment 249960 [details]
git diff to change MASTERSITES, WWW and update to 1.1 (version 3)

> Okay, understand. In this case could you please add a PORTSCOUT exclude
DONE
> And a comment why is it not recommended to update.
Anyone that discovers that there is a 2.x will discover, as I did, the
removal of BSD sed support. I wouldn't know where to put such an
announcement. That is the sort of thing that belongs in a CHANGELOG.
We don't cater to such things, outside of CHANGES || UPDATING.
IMHO this is better tasked to a pr(1).

Thanks! :)

--Chris

Comment 5 Zsolt Udvari 2024-04-14 08:35:16 UTC

(In reply to Chris Hutchinson from comment #4)
The "announcement" would be a simple comment line (beginning with #) inside the Makefile above the line of PORTSCOUT.

Plus remarks:
The post-extract target is unnecessary and in the do-install can copy ${WRKSRC}/${PORTNAME}.py to ${STAGEDIR}${PREFIX}/bin/sedsed directly.
It's okay to add LICENSE but should set LICENSE_FILE too.
Please check 'portfmt -D Makefile' for some cosmetic changes.

Thanks!

Created attachment 249988 [details]
git diff changing MASTERSITES, WWW, and update to 1.1 (version 4)

> The "announcement" would be a simple comment line (beginning with #)
> inside the Makefile above the line of PORTSCOUT.
Oh. You meant a REMARK/COMMENT. Sure. That makes perfect sense. DONE

> Plus remarks:
> The post-extract target is unnecessary and in the do-install can
> copy ${WRKSRC}/${PORTNAME}.py
> to ${STAGEDIR}${PREFIX}/bin/sedsed directly.
True. But requires modifying SHEBANG_FILES too. DONE

> It's okay to add LICENSE but should set LICENSE_FILE too.
MIT is an already accepted license, out of the box. In fact, I just added
BSD2CLAUSE to that list Friday (#278335). Should be committed soon.
I might also add; the file MIT reads as follows:
The license: MIT (MIT license / X11 license) is standard, please
read from the web.
So even if we wanted to, I think we're out of luck .:)

Please check 'portfmt -D Makefile' for some cosmetic changes.
I use portlint && portclippy. Both gave it the OK. Running portfmt reminded
me on 8 space tabs. Thanks. DONE :)

Thanks for all your time here!

Comment 7 Zsolt Udvari 2024-04-15 05:11:49 UTC

(In reply to Chris Hutchinson from comment #6)
License file: the Porter's Handbook suggests it (https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license - Example 32.). The sedsed's LICENSE contains the name of author too.

Created attachment 249990 [details]
git diff chanhing MASTERSITES, WWW, and updating to 1.1 (version 5)

Sorry. I was a complete idiot. You're completely right.
I had the wrong tab opened in my file browser and looked
the wrong port.
This should satisfy all your nits.

Thanks for all your time on this.

I promise not to be such a PITA next time. :)

--Chris

Comment 9 Zsolt Udvari 2024-04-15 09:17:25 UTC

(In reply to Chris Hutchinson from comment #8)
Thanks!
Did you run portlint? Should insert an empty line between LICENSE* and USES*.

Created attachment 249993 [details]
git diff updating MASTERSITES, WWW and to version 1.1

Well. That's embarrassing.

DONE

Comment 11 Zsolt Udvari 2024-04-16 06:03:31 UTC

Thanks. I changed MASTER_SITES to WWW.
Review: https://reviews.freebsd.org/D44802

(In reply to Zsolt Udvari from comment #11)
Any chance we can commit this now? :)

--Chris

Comment 13 Zsolt Udvari 2024-05-25 17:12:25 UTC

(In reply to Chris Hutchinson from comment #12)
Waiting for reply from diizzy.

But I'm thinking: what does it mean 'BSD sed support'? As I read its changelog I think sedsed supports many GNU's sed-releated extensions. So if you use only BSD-compatible sed-expressions it should work fine. Is it right?

(In reply to Zsolt Udvari from comment #13)
Following:
https://github.com/aureliojargas/sedsed/blob/main/CHANGELOG.md

I read GNU (sed) as being the *only* version supported...

> The old "home made" buggy parser for sed scripts was replaced by sedparse, a Python clone of the battle-tested GNU sed parser. The previous parsings bugs are now vanished and as a bonus, all the GNU sed extensions are now supported. 961624b 82c5d19

> Sedsed license has changed from MIT to GPLv3. This was necessary because sedparse is a derivative work from GNU sed GPL'd code. f5775be

1.1 is the last version to list (BSD)sed.
As such, I would like to propose that 1.1 be committed, and allowed
to become part of quarterly (which just got cut). Informing users that
this is the last version to support the BSD extensions.This will
allow users to "pkg lock" this version, if they're concerned with the
lack of BSD extensions, going forward.

After it's become available on the quarterly branch. Cut version 2 of
sedsed. Then those obsessed chronology, where software versions are
concerned. Will have the so-called "latest and greatest" version. :)

--Chris

Comment 15 Zsolt Udvari 2024-05-27 18:32:04 UTC

(In reply to Chris Hutchinson from comment #14)
Could you please provide an example which doesn't work with 2.0?
I'm not sed-expert but IMHO GNU-sed supports every BSD-sed feature (which is almost equal with POSIX: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html). So the BSD-sed compatible scripts is compatible with GNU-sed too (so the sedsed should work).

(In reply to Zsolt Udvari from comment #15)
There are many differences. But I think the most compelling
incompatible difference is the letters representing the different
options available to each of them, eg;
BSD:
-l Make output line buffered.
-i extension
LINUX:
-l N, --line-length=N
-i[suffix], --in-place[=suffix]

to name just 2.

Thanks for your time on this, Zsolt.

--Chris

Comment 17 Zsolt Udvari 2024-07-02 08:39:47 UTC

(In reply to Chris Hutchinson from comment #16)
And could you provide a sedsed-example which doesn't work as you expect?

Created attachment 251844 [details]
devel/sedsed: update to 2.0.0

Changelog
* Now supporting the GNU sed extra commands:
  e, F, L, Q, R, T, v, W, z. #14 #20 #33
* GNU sed extension: Now supporting the optional
  numeric argument for the following commands: l, q. #33
* GNU sed extension: Now supporting ~ and + in addresses. #53
* GNU sed extension: Now supporting the M flag for addresses. 961624b

I no longer have the time to discuss this further. We're transitioning
from a for-profit Corporation to a nonprofit Corporation, and I'm currently
preparing the paperwork, and financials for the State, Fed, and ARIN. While
doing so, I discovered someone is using our trade name for their product.
So now I'm also having to deal with a cease-and-desist order with our
attornies. So I'm just going to have to have to accept the undesired changes
in version 2.0.0, and come back to this when I can catch my breath.
The updated patch attached today moves this to current (2.0.0).

Thannks for all your time.

--Chris

Comment 19 commit-hook 2024-07-03 18:12:24 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0538f6d2b0520e89f66a769993eae86d25e01341

commit 0538f6d2b0520e89f66a769993eae86d25e01341
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2024-07-03 17:59:43 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-07-03 18:04:37 +0000

    devel/sedsed: update to 2.0.0

    Update WWW and use github.
    Update license (GPLv3).
    Set NO_ARCH and NO_BUILD.

    Changes: https://github.com/aureliojargas/sedsed/compare/v1.0...v2.0.0

    PR:             277367
    Approved by:    Submitter is maintainer
    Differential Revision:  https://reviews.freebsd.org/D44802

 devel/sedsed/Makefile | 28 ++++++++++++++--------------
 devel/sedsed/distinfo |  5 +++--
 2 files changed, 17 insertions(+), 16 deletions(-)

Comment 20 Zsolt Udvari 2024-07-03 18:13:07 UTC

Thanks for your work!
Please test the newest version and if it doesn't work as you expect can create sedsed1 port.