Bug 277608 - graphics/zathura-pdf-mupdf: Bump revision of mupdf update.
Summary: graphics/zathura-pdf-mupdf: Bump revision of mupdf update.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-10 09:41 UTC by mew14930xvi
Modified: 2024-03-11 14:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (uzsolt)


Attachments
Bump revision of mupdf update. (390 bytes, text/plain)
2024-03-10 09:41 UTC, mew14930xvi
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description mew14930xvi 2024-03-10 09:41:34 UTC
Created attachment 249063 [details]
Bump revision of mupdf update.

Bump revision of mupdf update.
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-03-10 17:31:41 UTC
I think it's unneeded:

$ ldd /usr/local/lib/zathura/libpdf-mupdf.so | grep mupdf
/usr/local/lib/zathura/libpdf-mupdf.so:
        libmupdf.so.1.23.11 => /usr/local/lib/libmupdf.so.1.23.11 (0x3800c1200000)
        libmupdf-third.so.1.23.11 => /usr/local/lib/libmupdf-third.so.1.23.11 (0x3800d745d000)

zathura-pdf-mupdf-0.4.1_1 from latest repository.
Comment 2 mew14930xvi 2024-03-10 20:33:24 UTC
That's because zathura-pdf-mupdf has been rebuilt.

$ grep libmupdf /usr/ports/graphics/mupdf/pkg-plist
lib/libmupdf-third.so
lib/libmupdf-third.so.%%SOVERSION%%
lib/libmupdf.so
lib/libmupdf.so.%%SOVERSION%%

$ grep SOVERSION /usr/ports/graphics/mupdf/Makefile
                SOVERSION=${DISTVERSION} \
PLIST_SUB=      SOVERSION=${PORTVERSION}

$ grep ^PORTVERSION /usr/ports/Mk/bsd.port.mk
PORTVERSION=    ${DISTVERSION:tl:C/([a-z])[a-z]+/\1/g:C/([0-9])([a-z])/\1.\2/g:C/:(.)/\1/g:C/[^a-z0-9+]+/./g}
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-03-10 20:54:10 UTC
(In reply to mew14930xvi from comment #2)
Sorry, I don't understand why need bump revision.

$ pkg info -l mupdf-1.23.11,1| grep libmupdf
        /usr/local/lib/libmupdf-third.so
        /usr/local/lib/libmupdf-third.so.1.23.11
        /usr/local/lib/libmupdf.so
        /usr/local/lib/libmupdf.so.1.23.11

So my mupdf is 1.23.11 (and epoch is 1, so the pkgversion is 1.23.11,1), SOVERSION is 1.23.11.

The installed zathura-pdf-mupdf is 0.4.1_1 and use /usr/local/lib/libmupdf.so.1.23.11 library as I shown in previous comment.

So the zathura-pdf-mupdf package in Latest repository uses the most recent mupdf package's library.

Did I miss something? I can use zathura-pdf-mupdf without any error or warning message.
Comment 4 mew14930xvi 2024-03-10 22:39:45 UTC
If I installed zathura-pdf-mupdf when mupdf was 1.23.9_1,1 and update mupdf, I get an error because libmupdf.so.1.23.9 is missing.
PORTREVISION needs to be changed to reinstall zathura-pdf-mupdf.
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-03-11 04:36:26 UTC
(In reply to mew14930xvi from comment #4)
Oh, okay. You install packages from source not binary repository.
Comment 6 mew14930xvi 2024-03-11 07:59:39 UTC
FreeBSD Porter's Handbook
https://docs.freebsd.org/en/books/porters-handbook/makefiles/

5.2.3.1. PORTREVISION

Examples of when PORTREVISION must be bumped:

 ・ Version bump of a port’s shared library dependency (in this case, someone
    trying to install the old package after installing a newer version of the
    dependency will fail since it will look for the old libfoo.x instead of
    libfoo.(x+1)).
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-03-11 14:14:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6a6478b468d2333c5d048a876141cc251090ce8a

commit 6a6478b468d2333c5d048a876141cc251090ce8a
Author:     Zsolt Udvari <uzsolt@FreeBSD.org>
AuthorDate: 2024-03-11 14:06:42 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-03-11 14:06:42 +0000

    graphics/zathura-pdf-mupdf: Bump revision of mupdf update.

    The graphics/mupdf port updated 1.23.9 -> 1.23.11 (f5af4656c).

    PR:             277608
    Approved by:    bofh (mentor)
    Differential Revision:  https://reviews.freebsd.org/D44296

 graphics/zathura-pdf-mupdf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 Zsolt Udvari freebsd_committer freebsd_triage 2024-03-11 14:15:48 UTC
Committed, thanks!