Bug 277690 - multimedia/libva: broken after update to 2.21.0
Summary: multimedia/libva: broken after update to 2.21.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-14 13:03 UTC by Marek Zarychta
Modified: 2024-03-14 21:24 UTC (History)
1 user (show)

See Also:
jbeich: maintainer-feedback+

Attachments
patch with fix (718 bytes, patch)
2024-03-14 13:03 UTC, Marek Zarychta 		jbeich: maintainer-approval-
Details | Diff
build log (28.67 KB, text/plain)
2024-03-14 14:55 UTC, Marek Zarychta 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Zarychta 2024-03-14 13:03:54 UTC 
Created attachment 249155 [details]
patch with fix
Comment 1 Marek Zarychta 2024-03-14 13:11:45 UTC 
Maybe PORTREVISION should be bumped too, but the port was never successfully built, so it's probably pointless.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2024-03-14 13:20:44 UTC 
I can't reproduce. Builds fine "as is" locally and inside poudriere on 13.2 amd64 + i386 and 15.0 amd64.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2024-03-14 13:22:55 UTC 
Comment on attachment 249155 [details]
patch with fix

The commit message fails to document "why?" beyond the opaque "broken after update ..."
Comment 4 Marek Zarychta 2024-03-14 14:55:05 UTC 
Created attachment 249164 [details]
build log

That's interesting. I was just performing a standard build of ports on stable/14 when bumped into this.
Comment 5 Marek Zarychta 2024-03-14 18:37:50 UTC 
Apparently not broken, but I need this fix.
Comment 6 Marek Zarychta 2024-03-14 20:06:11 UTC 
%%X11%%include/va/va_trace.h is right solution.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-03-14 21:04:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c0583872ee316ede5ce177ee72e9d4b7ffab8eec

commit c0583872ee316ede5ce177ee72e9d4b7ffab8eec
Author:     Vladimir Druzenko <vvd@freebsd.org>
AuthorDate: 2024-03-14 16:51:46 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-03-14 21:03:58 +0000

    multimedia/libva: unbreak X11=off build after 07b46bb45fbe

    ====> Checking for pkg-plist issues (check-plist)
    ===> Parsing plist
    ===> Checking for items in STAGEDIR missing from pkg-plist
    ===> Checking for items in pkg-plist which are not in STAGEDIR
    Error: Missing: include/va/va_trace.h
    ===> Error: Plist issues found.
    *** Error code 1

    PR:             277690

 multimedia/libva/pkg-plist | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 Jan Beich freebsd_committer freebsd_triage 2024-03-14 21:14:40 UTC 
(In reply to Marek Zarychta from comment #6)
Someone else provided the error message (aka "why?" or rationale) and the correct fix before I've seen yours.
Comment 9 Marek Zarychta 2024-03-14 21:24:46 UTC 
(In reply to Jan Beich from comment #8)
No problem Jan. I am glad you fixed it.