Bug 277798 - security/xray-core: Update to 1.8.8, config re-write fix
Summary: security/xray-core: Update to 1.8.8, config re-write fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/XTLS/Xray-core/rel...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2024-03-19 02:17 UTC by Kirill Lebedev
Modified: 2024-03-29 18:03 UTC (History)
1 user (show)

See Also:
kirill: maintainer-feedback+


Attachments
Xray Core patch to 1.8.8 (9.36 KB, application/mbox)
2024-03-19 02:17 UTC, Kirill Lebedev
no flags Details
Zray patch to 1.8.8 (9.36 KB, patch)
2024-03-19 02:19 UTC, Kirill Lebedev
kirill: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kirill Lebedev 2024-03-19 02:17:21 UTC
Created attachment 249291 [details]
Xray Core patch to 1.8.8

Changes done:

1. Xray updated to version 1.8.8 (latest stable)
2. Geodata and Site data files updated
3. Sample macro included to avoid config overwrite during update/reinstall

Testing done
1. Manual test of config changes maintained
2. portlint is OK
3. make test is OK
4. poudriere tests are OK
Comment 1 Kirill Lebedev 2024-03-19 02:19:31 UTC
Created attachment 249292 [details]
Zray patch to 1.8.8
Comment 2 Kirill Lebedev 2024-03-23 00:00:39 UTC
jbo@freebsd.org Can you review/merge?
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2024-03-26 19:17:52 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

Q/A: PORTREVISION should be removed


Thanks!
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2024-03-28 15:34:45 UTC
This fails to install.

Maybe some missing entries in files/ ?

===>  Installing xray as /wrkdirs/usr/ports/security/xray-core/work/stage/usr/local/bin/xray
/bin/mkdir -p /wrkdirs/usr/ports/security/xray-core/work/stage/usr/local/etc/xray-core
/bin/mkdir -p /wrkdirs/usr/ports/security/xray-core/work/stage/usr/local/share/xray-core
install  -m 0644 /portdistfiles/go/security_xray-core/xtls-Xray-core-v1.8.8_GH0/geoip.dat /wrkdirs/usr/ports/security/xray-core/work/stage/usr/local/share/xray-core/geoip.dat
install  -m 0644 /portdistfiles/go/security_xray-core/xtls-Xray-core-v1.8.8_GH0/dlc.dat /wrkdirs/usr/ports/security/xray-core/work/stage/usr/local/share/xray-core/geosite.dat
install  -m 0644 /usr/ports/security/xray-core/files/*.json.sample /wrkdirs/usr/ports/security/xray-core/work/stage/usr/local/etc/xray-core/
install: /usr/ports/security/xray-core/files/*.json.sample: No such file or directory
*** Error code 71

Would you have a look at it?
Comment 5 Kirill Lebedev 2024-03-28 18:02:08 UTC
fernape@freebsd.org. I will take a look. Did you fully apply patch? I renames json files to *.json.sample. This is must for install to succeed.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-03-29 18:03:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=31fd3622834ee27c7b24bb042e7e667db02c6c58

commit 31fd3622834ee27c7b24bb042e7e667db02c6c58
Author:     Kirill Lebedev <kirill@drlebedev.com>
AuthorDate: 2024-03-29 17:57:46 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2024-03-29 17:57:46 +0000

    security/xray-core: Update to 1.8.8, config re-write fix

    ChangeLog: https://github.com/XTLS/Xray-core/releases/tag/v1.8.8

    PR:             277798
    Reported by:    kirill@drlebedev.com (maintainer)

 security/xray-core/Makefile                        | 12 ++++++------
 security/xray-core/distinfo                        | 22 +++++++++++-----------
 .../{00_log.json => 00_log.json.sample} (mode +x)  |  0
 .../{01_api.json => 01_api.json.sample} (mode +x)  |  0
 .../{02_dns.json => 02_dns.json.sample} (mode +x)  |  0
 ...uting.json => 03_routing.json.sample} (mode +x) |  0
 ...policy.json => 04_policy.json.sample} (mode +x) |  0
 ...unds.json => 05_inbounds.json.sample} (mode +x) |  0
 ...nds.json => 06_outbounds.json.sample} (mode +x) |  0
 ...ort.json => 07_transport.json.sample} (mode +x) |  0
 ...8_stats.json => 08_stats.json.sample} (mode +x) |  0
 ...verse.json => 09_reverse.json.sample} (mode +x) |  0
 security/xray-core/pkg-plist                       | 20 ++++++++++----------
 13 files changed, 27 insertions(+), 27 deletions(-)
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2024-03-29 18:03:53 UTC
You're right, I made a mistake when applying the patch.

Thanks!