Bug 278085 - qlnxe: setting mac address with ifconfig does not update NIC MAC filter [PATCH]
Summary: qlnxe: setting mac address with ifconfig does not update NIC MAC filter [PATCH]
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 13.3-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Kevin Bowling
URL:
Keywords: easy, vendor
Depends on:
Blocks:
 
Reported: 2024-04-01 05:32 UTC by Keith Reynolds
Modified: 2024-09-29 04:02 UTC (History)
2 users (show)

See Also:
kbowling: mfc-stable14+

Attachments
patch that checks for and uses MAC address set by ifconfig (781 bytes, patch)
2024-04-01 05:33 UTC, Keith Reynolds 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Reynolds 2024-04-01 05:32:43 UTC 
The qlnxe driver always sets the NIC's rx mac address to the card's default MAC, ignoring any MAC address set via ifconfig.
Comment 1 Keith Reynolds 2024-04-01 05:33:52 UTC 
Created attachment 249621 [details]
patch that checks for and uses MAC address set by ifconfig
Comment 2 Kevin Bowling freebsd_committer freebsd_triage 2024-05-28 06:05:51 UTC 
(In reply to Keith Reynolds from comment #1)
on CURRENT, where this must land first, it generates a build error:

/usr/src/sys/dev/qlnx/qlnxe/qlnx_os.c:7081:56: error: cast from 'const char *' to 'char *' drops const qualifier [-Werror,-Wcast-qual]
 7081 |                 rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, LLADDR(sdl));
      |                                                                      ^
/usr/src/sys/net/if_dl.h:68:29: note: expanded from macro 'LLADDR'
   68 | #define LLADDR(s) ((caddr_t)((s)->sdl_data + (s)->sdl_nlen))
      |
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-05 19:14:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=792226e53023cb09566cb78b2135b052e9b62e0e

commit 792226e53023cb09566cb78b2135b052e9b62e0e
Author:     Keith Reynolds <keith.reynolds@hpe.com>
AuthorDate: 2024-08-05 19:10:18 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-08-05 19:10:18 +0000

    qlnxe: Allow MAC address override

    The qlnxe driver always sets the NIC's rx mac address to the card's
    default MAC, ignoring any MAC address set via ifconfig.

    PR:             278085
    MFC after:      1 week

 sys/dev/qlnx/qlnxe/qlnx_os.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-08-13 19:35:04 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a9376f5caf1cdcee074601dbd838a1c5450e283c

commit a9376f5caf1cdcee074601dbd838a1c5450e283c
Author:     Keith Reynolds <keith.reynolds@hpe.com>
AuthorDate: 2024-08-05 19:10:18 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-08-13 19:34:10 +0000

    qlnxe: Allow MAC address override

    The qlnxe driver always sets the NIC's rx mac address to the card's
    default MAC, ignoring any MAC address set via ifconfig.

    PR:             278085

    (cherry picked from commit 792226e53023cb09566cb78b2135b052e9b62e0e)

 sys/dev/qlnx/qlnxe/qlnx_os.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-09-29 04:02:54 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=03f2916114647def8b68f1a7f4aee65aec5632c7

commit 03f2916114647def8b68f1a7f4aee65aec5632c7
Author:     Keith Reynolds <keith.reynolds@hpe.com>
AuthorDate: 2024-08-05 19:10:18 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-09-29 04:01:28 +0000

    qlnxe: Allow MAC address override

    The qlnxe driver always sets the NIC's rx mac address to the card's
    default MAC, ignoring any MAC address set via ifconfig.

    PR:             278085

    (cherry picked from commit 792226e53023cb09566cb78b2135b052e9b62e0e)

 sys/dev/qlnx/qlnxe/qlnx_os.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)