Created attachment 249654 [details] Update patch This patch updates the Limine bootloader to the latest version: 7.3.0. Changelog file can be found at https://github.com/limine-bootloader/limine/releases/download/v7.3.0/ChangeLog
Hello, portlint: If and only if your port is DOCSDIR-safe (that is, a user can override DOCSDIR when building this port and the port will still work correctly) consider using DOCSDIR macro; if you are unsure if this port is DOCSDIR-safe, then ignore this warning Is there any particular reason for not using a DOCS option in this port? Thanks
(In reply to Nuno Teixeira from comment #1) Hello, I am not sure I understand the request/concern. I am not a ports expert, I am just the upstream maintainer of Limine. Could you please be more specific?
Created attachment 249734 [details] Add DOCS knob Following https://docs.freebsd.org/en/books/porters-handbook/book/#install-documentation , we can have a DOCS option (default ON) to control installing documentation. - PORTDOCS list includes what port install by default and it automaticly adds list to PLIST (i.e., no need to add docs list in pkg-plist) If more control over installed docs needed we can do it using do-intall-DOCS target where we can install only the wanted documentation and also check source configure and check --enable/--disable options regarding docs build/install. - Fixed pkg-plist to pet portlint using %%DATADIR%% IMO, with this patch, we can have a fully compliant port with DOCS.
(In reply to Nuno Teixeira from comment #3) Looks good to me. Thanks for explaining!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e27fd56f53fbfc229a6bf970117a84e2290a2f96 commit e27fd56f53fbfc229a6bf970117a84e2290a2f96 Author: mintsuki <mintsuki@protonmail.com> AuthorDate: 2024-04-05 08:48:56 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-04-05 08:48:56 +0000 sysutils/limine: Update to 7.3.0 - pet portlint - add DOCS knob ChangeLog: https://github.com/limine-bootloader/limine/releases/download/v7.3.0/ChangeLog PR: 278125 sysutils/limine/Makefile | 6 +++++- sysutils/limine/distinfo | 6 +++--- sysutils/limine/pkg-plist | 21 ++++++++------------- 3 files changed, 16 insertions(+), 17 deletions(-)
Committed, thanks!