Bug 278146 - dns/nsd: update to 4.9.1
Summary: dns/nsd: update to 4.9.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL: https://lists.nlnetlabs.nl/pipermail/...
Keywords: buildisok, patch
Depends on:
Blocks:
 
Reported: 2024-04-03 16:38 UTC by Marek Zarychta
Modified: 2024-04-04 16:03 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jaap)


Attachments
upgrade patch (1.88 KB, patch)
2024-04-03 16:38 UTC, Marek Zarychta
no flags Details | Diff
upgrade patch v2 (1.88 KB, patch)
2024-04-04 05:53 UTC, Marek Zarychta
zarychtam: maintainer-approval-
Details | Diff
patch to upgrade (1.55 KB, patch)
2024-04-04 14:53 UTC, Jaap Akkerhuis
jaap: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Zarychta 2024-04-03 16:38:20 UTC
Created attachment 249684 [details]
upgrade patch

NSD 4.9.0 was released today. The last time I was using it with students spotted missing /var/db/%%NSDUSER%% dir, so let's fix it. Adding autoreconf was required for successful build.

- Update port to the most recent version
- Fix missing /var/db/%%NSDUSER%% in pkg-plist
- Add autoreconf in USES

Changelog: https://lists.nlnetlabs.nl/pipermail/nsd-users/2024-April/003297.html
Comment 1 Marek Zarychta 2024-04-04 05:53:53 UTC
Created attachment 249695 [details]
upgrade patch v2

Let's set less restrictive permissions on restored /var/db/nsd/, the same as they were before the upgrade to 4.8.0  (before commit 44e39403d8ddfd935dd045c3ef93db26c7329b1b).

While preserving nsd.db is no more required, this directory is still important on slaves/secondaries, to keep xfrd.state file. Without it, NSD sends errors to syslog as xfr daemon is no longer able to save slave zone information on shutdown.
Comment 2 Jaap Akkerhuis 2024-04-04 14:50:55 UTC
Thanks for the suggestions!

There was a problem at the repository and a new release was cut. I'll send an updated patch using this version
Comment 3 Jaap Akkerhuis 2024-04-04 14:53:55 UTC
Created attachment 249707 [details]
patch to upgrade

Patch using release 4.9.1
Comment 4 Marek Zarychta 2024-04-04 15:34:51 UTC
(In reply to Jaap Akkerhuis from comment #2)
>There was a problem at the repository and a new release was cut.
>I'll send an updated patch using this version

Weird... it works fine for me, it built fine in Poudriere and I have been running 4.9.0 on 4 servers since yesterday, but OK.
Comment 6 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-04-04 15:51:32 UTC
Comment on attachment 249695 [details]
upgrade patch v2

Maintainer has submitted another patch with more recent versions.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-04-04 15:56:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=465844833afc6b6ebf949e7095ba4cbbc3530ca2

commit 465844833afc6b6ebf949e7095ba4cbbc3530ca2
Author:     Jaap Akkerhuis <jaap@NLnetLabs.nl>
AuthorDate: 2024-04-04 14:41:45 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2024-04-04 15:53:27 +0000

    dns/nsd: Update version 4.8.0=>4.9.1

    Changelog : https://nlnetlabs.nl/news/2024/Apr/04/nsd-4.9.1-released/

    PR:             278146
    Reported by:    zarychtam@plan-b.pwste.edu.pl
    Approved by:    submitter is maintainer

 dns/nsd/Makefile  | 3 +--
 dns/nsd/distinfo  | 6 +++---
 dns/nsd/pkg-plist | 3 ++-
 3 files changed, 6 insertions(+), 6 deletions(-)
Comment 8 Marek Zarychta 2024-04-04 16:03:36 UTC
(In reply to Muhammad Moinur Rahman from comment #6)

Thank you for committing Muhammad ! Thank you for the updated patch Jaap ! 

I hope they haven't introduced anything suspicious with the update to 4.9.1 since in our ports tree 4.9.0 was building fine. Only joking of course. Presumably, other build systems are less sophisticated than our ports tree[1].

1. https://lists.nlnetlabs.nl/pipermail/nsd-users/2024-April/003299.html