Bug 278154 - print/lilypond: fix build with NLS option turned off
Summary: print/lilypond: fix build with NLS option turned off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-03 21:36 UTC by Martin Neubauer
Modified: 2024-04-04 13:32 UTC (History)
1 user (show)

See Also:

Attachments
patch fixing dependencies for NLS (843 bytes, patch)
2024-04-03 21:36 UTC, Martin Neubauer 		m.ne: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Neubauer 2024-04-03 21:36:28 UTC 
Created attachment 249686 [details]
patch fixing dependencies for NLS

Lilypond always expects gettext-tools to be present during build leading to a failing configure stage when the NLS option is turned off. The patch fixes the dependencies for either value of NLS.

(Thanks D'Arcy Cain for pointing out the problem.)
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-04 10:37:31 UTC 
(Note to self: bump portrevision as this changes affects pkg)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-04-04 13:31:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=04761e4a269f05cde037eb6364db0f1990b88878

commit 04761e4a269f05cde037eb6364db0f1990b88878
Author:     Martin Neubauer <m.ne@gmx.net>
AuthorDate: 2024-04-04 13:28:55 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-04-04 13:30:46 +0000

    print/lilypond: Fix build with NLS option turned off

    PR:             278154

 print/lilypond/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-04 13:32:51 UTC 
Committed, thanks!