Bug 278228 - archivers/snappy: Improvements to port
Summary: archivers/snappy: Improvements to port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vanilla I. Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-07 10:54 UTC by Daniel Engberg
Modified: 2024-04-07 17:00 UTC (History)
0 users

See Also:
vanilla: maintainer-feedback+

Attachments
Patch for snappy (2.07 KB, patch)
2024-04-07 10:54 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-04-07 10:54:14 UTC 
Created attachment 249798 [details]
Patch for snappy

- Convert from PORTVERSION to DISTVERSION
  https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
- Define LICENSE_FILE
  https://docs.freebsd.org/en/books/porters-handbook/book/#licenses
- Remove CMAKE_BUILD_TYPE, defined by framework
  https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n34
- Use = instead of += for PLIST_SUB, SUB_FILES, SUB_LIST

Compile tested on 14.0-RELEASE (amd64)
Poudriere testport OK, 14.0-RELEASE (amd64)
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-04-07 16:52:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ab0d5c811bbb3ea28b023b5d6d37871078cd100f

commit ab0d5c811bbb3ea28b023b5d6d37871078cd100f
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-04-07 16:04:35 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-04-07 16:50:07 +0000

    archivers/snappy: Improve port

    * Convert from PORTVERSION to DISTVERSION
    * Define LICENSE_FILE
    * Remove CMAKE_BUILD_TYPE
    * Use = instead of += for PLIST_SUB, SUB_FILES, SUB_LIST
    * Rearrange port for better readability

    PR:             278228
    Reviewed by:    vanilla (maintainer)

 archivers/snappy/Makefile           | 24 ++++++++++++++----------
 archivers/snappy/files/snappy.pc.in |  2 +-
 archivers/snappy/pkg-plist          |  2 +-
 3 files changed, 16 insertions(+), 12 deletions(-)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-04-07 16:58:07 UTC 
Commmitted, thanks