Created attachment 249935 [details] Kodi 21.0
Created attachment 249936 [details] testport log (bzip2)
Hello, Using MASTER_SITES and USE_GITHUB=yes needs adjusting. https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-multiple --- When fetching multiple files from GitHub, sometimes the default distribution file is not fetched from GitHub. To disable fetching the default distribution, set: USE_GITHUB= nodefault --- Could you take a look at it? Cheers
In the case of Kodi, upstream removed binaries from source, hence the use of MASTER_SITES. The source itself still comes from GitHub, which is the `default distribution file'? It seems to build correctly.
I'll take it
I am currently updating all the kodi addons and except the kodi libretro addon they were all easy to update/fix. Buildlog is at: https://ports.bluelife.at/builds/20240426-19:03:08.36331/ Code is available there: https://codeberg.org/decke/ports
Looks like a new dependency. Let me take a closer look at this https://github.com/libretro/libretro-common.
Created attachment 250261 [details] game.libretro 21.0.6 Download the tarball and add CMAKE_ARGS -DLIBRETROCOMMON_URL should be enough to fix it. Test building now.
Created attachment 250281 [details] game.libretro 21.0.6 (add one more dependency) There is one more dependency: rcheevos.
Created attachment 250282 [details] testport log It failed to build (for me anyway). Looks like upstream's depends/common/rcheevos/CMakeLists.txt does not actually install the project, despite showing up in build log.
I can reproduce it and the problem seems to be the install location. [ 28% 15/52] cd /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/rcheevos/src/rcheevos-build && /usr/local/bin/cmake --build . --target install && /usr/local/bin/cmake -E touch /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/rcheevos/src/rcheevos-stamp/rcheevos-install [ 0% 1/1] Install the project... -- Install configuration: "" -- Installing: /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/stage/usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/depends/lib/librcheevoslib.a -- Installing: /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/stage/usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/depends/include/rcheevos/rcheevos.h -- Installing: /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/stage/usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/depends/include/rcheevos/rconsoles.h -- Installing: /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/stage/usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/depends/include/rcheevos/rhash.h -- Installing: /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/stage/usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/depends/include/rcheevos/rurl.h [ 30% 16/52] cd /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build && /usr/local/bin/cmake -E make_directory /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/CMakeFiles && /usr/local/bin/cmake -E touch /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/CMakeFiles/rcheevos-complete && /usr/local/bin/cmake -E touch /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/rcheevos/src/rcheevos-stamp/rcheevos-done There you can see the install location is /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/stage/usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/depends/include/rcheevos/ but actually should be /usr/home/decke/dev/ports/games/kodi-addon-game.libretro/work/.build/build/depends/include to match RCHEEVOS_INCLUDE_DIR. Since I could not find any specific destination in build/rcheevos/src/rcheevos/CMakeLists.txt my guess is that the ports framework sets some cmake variable which is picked up incorrectly but I haven't found it yet.
I've CC'd game.libretro maintainer. Probably he also has some time to have a look.
I found a workaround for this problem. Builds fine locally now, poudriere builds are running.
kodi game.* ports only set of xml/icons, all binaries installed as dep ports.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=edac4920e0a19b7c6979fb2b4a891418d2fbd871 commit edac4920e0a19b7c6979fb2b4a891418d2fbd871 Author: yzrh <yzrh@noema.org> AuthorDate: 2024-05-25 19:24:48 +0000 Commit: Bernhard Froehlich <decke@FreeBSD.org> CommitDate: 2024-05-26 05:32:32 +0000 multimedia/kodi: Update to 21.0 PR: 278334 multimedia/kodi/Makefile | 71 +- multimedia/kodi/distinfo | 24 +- .../files/patch-cmake_modules_FindCrossGUID.cmake | 37 +- .../patch-cmake_modules_FindLibDvdCSS.cmake (gone) | 11 - .../patch-cmake_modules_FindLibDvdNav.cmake (gone) | 11 - ...patch-cmake_modules_FindLibDvdRead.cmake (gone) | 11 - multimedia/kodi/files/patch-ffmpeg6-support (gone) | 2155 -------------------- ...tch-xbmc_cores_AudioEngine_Sinks_AESinkALSA.cpp | 4 +- ..._cores_AudioEngine_Utils_AEELDParser.cpp (gone) | 11 - multimedia/kodi/pkg-plist | 275 +-- 10 files changed, 156 insertions(+), 2454 deletions(-)
Kodi 21.0 has landed! Thanks everyone! I decided to only bump PORTREVISION for the libretro addons because they seem to work. Since I have prepared updates for some addons I will create a separate PR for that.