Bug 278468 - shells/fish: Update to 3.7.1 and fix Makefile
Summary: shells/fish: Update to 3.7.1 and fix Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alan Somers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-19 22:10 UTC by Andrew Fyfe
Modified: 2024-05-22 20:05 UTC (History)
0 users

See Also:
asomers: maintainer-feedback+

Attachments
update shells/fish to 3.7.1 (15.36 KB, patch)
2024-04-19 22:10 UTC, Andrew Fyfe 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fyfe 2024-04-19 22:10:53 UTC 
Created attachment 250094 [details]
update shells/fish to 3.7.1

- Update to fish 3.7.1.
- Remove zfs feature check patch; included upstream.
- Remove post install step to strip binaries; binaries are stripped
  durting install.
- Add post install steps to remove documentation and/or manual pages if
  DOCS and/or MANPAGES are not enabled. Be default fish always installs
  documentation and manual pages.
Comment 1 Alan Somers freebsd_committer freebsd_triage 2024-04-20 14:17:34 UTC 
LGTM!  Thanks for the patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-22 18:38:09 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b77636e7a49dc610c5816bf9a9011546cf6343fb

commit b77636e7a49dc610c5816bf9a9011546cf6343fb
Author:     Andrew Fyfe <andrew@fyfe.gb.net>
AuthorDate: 2024-02-24 17:13:50 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2024-05-22 18:31:28 +0000

    shells/fish: update to 3.7.1 and fix Makefile

    - Update to fish 3.7.1.
    - Remove zfs feature check patch; included upstream.
    - Remove post install step to strip binaries; binaries are stripped
      durting install.
    - Add post install steps to remove documentation and/or manual pages if
      DOCS and/or MANPAGES are not enabled. Be default fish always installs
      documentation and manual pages.

    PR:             278468
    Approved by:    asomers (maintainer)

 shells/fish/Makefile  | 26 ++++++++++++++++----------
 shells/fish/distinfo  |  8 +++-----
 shells/fish/pkg-plist | 51 +++++++++++++++++++++++++++++++++++++++++++++++++--
 3 files changed, 68 insertions(+), 17 deletions(-)